Skip to content

Commit 4a55f19

Browse files
committed
throw exception in tests for older versions
1 parent a6b6664 commit 4a55f19

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

tests/Mocks/TestExcelMember.php

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,17 @@
44

55
use SilverStripe\Dev\TestOnly;
66
use SilverStripe\Security\Member;
7+
use Exception;
78

89
class TestExcelMember extends Member implements TestOnly
910
{
10-
// Empty
11+
public function onBeforeWrite()
12+
{
13+
parent::onBeforeWrite();
14+
15+
// For older ss versions that do not validate emails
16+
if ($this->Email && !filter_var($this->Email, FILTER_VALIDATE_EMAIL)) {
17+
throw new Exception("Email is not valid");
18+
}
19+
}
1120
}

tests/data/members-invalid.csv

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
FirstName;Surname;Email
2-
3-
test;invalid;not-a-valid-email
1+
ClassName;FirstName;Surname;Email
2+
LeKoala\ExcelImportExport\Test\Mocks\TestExcelMember;test;valid;[email protected]
3+
LeKoala\ExcelImportExport\Test\Mocks\TestExcelMember;test;invalid;not-a-valid-email

0 commit comments

Comments
 (0)