Skip to content

Commit 4a02bc2

Browse files
lhcapscursoragent
andcommitted
docs(planning): finalize phase21d commit references and smoke results
Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 4aa564a commit 4a02bc2

4 files changed

Lines changed: 14 additions & 4 deletions

File tree

.planning/ROADMAP.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1163,7 +1163,7 @@ This patch addresses accumulated traceability drift — several phases completed
11631163
**Phase 21A commits:** `86416bf` (extraction) + `27d78bb` (cleanup round 1) + `2f3a1c4` (cleanup round 2 — leftovers)
11641164
**Phase 21B commit:** `3693061` (runtime sync) + finalization commit
11651165
**Phase 21C commit:** `d667962e` (prop surface cleanup) + `2227632e` (groundTruth overlay restored, Overview text neutralized)
1166-
**Phase 21D commit:** [pending] (inspector routing boundary — fake state removed)
1166+
**Phase 21D commit:** `4aa564a5` (inspector routing boundary — fake state removed)
11671167
**Phase 21A status:** Done — App composition boundary, AppRoutes extraction, panel extractions, import cleanup, dead code removal. Full verification gate passed.
11681168
**Phase 21B status:** Done (10/10) — FE/BE runtime sync, /api/health/runtime/status endpoint, useRuntimeStatus hook, ReadinessStrip reads real state, 3 controllers extracted. App.tsx reduced from 529 to ~144 lines. runtimeState.health derives from backend truth. Browser smoke passed. Dev boot text corrected.
11691169
**Phase 21C status:** Done — AppRoutes prop surface reduced from 23 to 17 props (26% reduction). Threshold/annotation/pipeline state moved to feature-local components. JobsPanel owns threshold locally, AnnotationEnginePanel owns all annotation state, ShellHeader cleaned up. groundTruth overlay regression fixed, Overview neutral pipeline text restored. 65/65 tests pass. 21D pending.

.planning/STATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ Last updated: 2026-05-05.
3333
- Phase 21A ✅ Done — App composition boundary, AppRoutes extraction, panel extractions, import cleanup, dead code removal, full verification gate passed.
3434
- Phase 21B ✅ Done (10/10) — FE/BE runtime sync, /api/health/runtime/status endpoint, useRuntimeStatus hook, ReadinessStrip reads real state, useDatasetsController/useInferenceJobController/useEvaluationController extracted. App.tsx reduced from 529 to ~144 lines. runtimeState.health now derives from backend truth. Browser smoke passed.
3535
- Phase 21C ✅ Done — AppRoutes prop surface reduced from 23 to 17 props (26% reduction). Threshold/annotation/pipeline state moved to feature-local components. JobsPanel owns threshold, AnnotationEnginePanel owns annotation state, ShellHeader cleaned up. 65/65 tests pass, all runtime truth invariants preserved. groundTruth overlay regression fixed, Overview neutral pipeline text restored. 21D pending.
36-
- Phase 21D ✅ Done — InspectorRouter props refactored. Fake annotation/pipeline state removed from AppRoutes. AnnotationInspector and PipelineInspector rendered as honest embedded-notice panels for their respective sections. 4 unused types removed from inspector.types.ts. Option A1 chosen (section-owned inspector). Phase 21 fully closed.
36+
- Phase 21D ✅ Done — Commit `4aa564a5`. InspectorRouter props refactored. Fake annotation/pipeline state removed from AppRoutes. AnnotationInspector and PipelineInspector rendered as honest embedded-notice panels for their respective sections. 4 unused types removed from inspector.types.ts. Option A1 chosen (section-owned inspector). Phase 21 fully closed.
3737
- Phase 21 (Frontend split completion) Phase 21A + 21B + 21C + 21D all complete.
3838
- Phase 22A (Test harness) pending
3939
- Phase 22B (Production test suite) pending

.planning/phases/phase-21-frontend-feature-split-completion/21D-REVIEW.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ All checks passed:
8181
| `grep "pipelineDefinition={demoSnapshot"` | 0 results |
8282
| `grep "pipelineValidation={validatePipelineDefinition"` | 0 results |
8383
| `grep "useRuntimeStatus" (only App.tsx)` | PASS |
84+
| Playwright nav smoke (10 checks) | **PASS** — all 8 sections navigate without errors, no console errors |
8485

8586
---
8687

.planning/phases/phase-21-frontend-feature-split-completion/21D-SUMMARY.md

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
**Phase:** 21D
44
**Date:** 2026-05-05
55
**Status:** Complete
6-
**Commit:** [pending]
6+
**Commit:** `4aa564a5`
77

88
---
99

@@ -142,7 +142,16 @@ Not Option B because:
142142

143143
## Browser Smoke
144144

145-
Not run — verification limited to typecheck/test/lint/build. The change is structural refactor only (no visual/behavioral changes to panel layouts). The honest embedded-notice rendering is strictly internal to `InspectorRouter`.
145+
**PASS — Playwright navigation smoke (2026-05-05)**
146+
147+
Ran `pnpm playwright test e2e/navigation.spec.ts --project=chromium` against `http://localhost:5173`.
148+
149+
All 10 checks passed:
150+
- 8 nav sections navigate without errors (Command, Media, Versions, Annotate, Pipeline, Jobs, Replay, Diff)
151+
- No console errors on initial load
152+
- All 8 nav buttons are visible
153+
154+
This confirms the `InspectorRouter` refactor does not break navigation or introduce console errors.
146155

147156
---
148157

0 commit comments

Comments
 (0)