feat(ui): split submit into metadata selector + submit by ErykKul · Pull Request #54 · libis/rdm-integration-frontend

ErykKul · 2025-09-16T13:15:53Z

@AI-Tool: Copilot

Summary

Split the original submit flow into two standalone components (metadata selector for new datasets, files-only submit) to improve clarity and routing.
Updated routes and compare component to direct new datasets to metadata selector, existing to submit; fixed PrimeNG imports; added tests; addressed lint.
Motivation: resolve CI build issues and make governance-friendly, testable units; no behavior regressions for existing datasets.

AI Provenance (required for AI-assisted changes)

Prompt: Implement metadata selector component, split submit logic as discussed in conversation; add tests; build, test, lint; create PR via governance context.
Model: GitHub Copilot gpt-5
Date: 2025-09-16T13:15:34Z
Author: @ErykKul
Role: deployer

Compliance checklist

No secrets/PII
Transparency notice updated (if user-facing)
Agent logging enabled (actions/decisions logged)
Kill-switch / feature flag present for AI features
No prohibited practices under EU AI Act
Human oversight retained (required if high-risk or agent mode)
Risk classification: limited
Personal data: no
DPIA: N/A
Automated decision-making: no
Agent mode used: no
GPAI obligations: N/A (if Role: provider)
Vendor GPAI compliance reviewed: N/A (if Role: deployer)
License/IP attestation
Attribution: N/A
Oversight plan: N/A

Change-type specifics

Security review: N/A
Media assets changed:
- AI content labeled
- C2PA: N/A
UI changed:
- Accessibility review (EN 301 549/WCAG)
- Accessibility statement: N/A
Deploy/infra changed:
- Privacy notice: N/A
- Lawful basis: N/A
- Retention schedule: N/A
- NIS2 applicability: N/A
- Incident response plan: N/A
Backend/API changed:
- ASVS: N/A
Log retention policy: N/A
Data paths changed:
- TDM: N/A
- TDM compliance: N/A

Tests & Risk

Unit/integration tests added/updated
Security scan passed
Rollback plan: Revert PR; disable feature path by routing to original submit if needed.
Smoke test: N/A
Docs updated (if needed)

…aSelector components" This reverts commit 84b8af5.

github-actions · 2025-09-16T13:16:03Z

Code Review Agent (Python)\n

No Python files changed. Skipping analysis.

github-actions · 2025-09-16T13:16:05Z

AI Governance checks failed

Please fix the following before re-running checks:

Ensure PR body includes provenance fields:
- Prompt
- Model
- Date
- Author
- No secrets/PII (checkbox)
Complete compliance checklist items required for your change type (transparency notice, DPIA, logging, kill-switch, risk classification, human oversight, security review, vendor GPAI review).
Add a rollback note if the change is risky (authz, data export, evaluation logic, etc.).

Helpful links:

PR template (provenance): https://github.com/libis/ai-transition/blob/main/.github/pull_request_template.md
Risk mitigation matrix: https://github.com/libis/ai-transition/blob/main/governance/risk_mitigation_matrix.md
Reusable governance workflow: https://github.com/libis/ai-transition/blob/main/.github/workflows/ai-governance.yml

After edits, push updates or re-run the workflow to validate.

…ents, streamline submit process

github-actions · 2025-09-16T13:24:20Z

Code Review Agent (Python)\n

No Python files changed. Skipping analysis.

…tion, and error handling; fix TDZ in subscriptions

…component

github-actions · 2025-09-16T14:01:02Z

Code Review Agent (Python)\n

No Python files changed. Skipping analysis.

… remove unused code

github-actions · 2025-09-16T14:29:10Z

Code Review Agent (Python)\n

No Python files changed. Skipping analysis.

github-actions · 2025-09-16T14:29:35Z

Code Review Agent (Python)\n

No Python files changed. Skipping analysis.

…ove unused 'done' property

…rning icon

github-actions · 2025-09-16T14:46:54Z

Code Review Agent (Python)\n

No Python files changed. Skipping analysis.

ErykKul · 2025-09-16T14:59:49Z

/gov

github-actions · 2025-09-16T15:00:00Z

Governance Agent Report\n\n

PR: #54 by @ErykKul

Changed files (35):

angular.json
eslint.config.mjs
karma.conf.js
src/app/app.component.spec.ts
src/app/app.routs.ts
src/app/compare/compare.component.spec.ts
src/app/compare/compare.component.ts
src/app/compute/compute.component.spec.ts
src/app/compute/compute.component.ts
src/app/connect/connect.component.spec.ts
src/app/connect/connect.component.ts
src/app/data.service.spec.ts
src/app/datafile/datafile.component.spec.ts
src/app/datafile/datafile.component.ts
src/app/doi.lookup.service.spec.ts
src/app/download/download.component.spec.ts
src/app/download/download.component.ts
src/app/executablefile/executablefile.component.spec.ts
src/app/executablefile/executablefile.component.ts
src/app/metadata-selector/metadata-selector.component.html
src/app/metadata-selector/metadata-selector.component.scss
src/app/metadata-selector/metadata-selector.component.spec.ts
src/app/metadata-selector/metadata-selector.component.ts
src/app/oauth.service.spec.ts
src/app/plugin.service.spec.ts
src/app/repo.lookup.service.spec.ts
src/app/shared/constants.ts
src/app/shared/notification.service.ts
src/app/shared/types.ts
src/app/submit/submit.component.html
src/app/submit/submit.component.spec.ts
src/app/submit/submit.component.ts
src/app/submitted-file/submitted-file.component.ts
src/app/utils.service.ts
tests/governance/smoke.test.js

Detected change types:

userUI
backend

Missing or incomplete items:

Transparency notice updated
OWASP ASVS review or ASVS:

Tip: Use the PR template fields to satisfy these checks.

Run /gov help for commands. Also try: /gov links and /gov autofill apply.

github-actions · 2025-09-16T15:00:01Z

/gov copilot

github-actions · 2025-09-16T15:00:02Z

/gov links

github-actions · 2025-09-16T15:00:02Z

/gov autofill apply

github-actions · 2025-09-16T15:00:04Z

Governance reports summary

Run ID: 17769693985

ScanCode (licenses)

Copyleft findings (AGPL/GPL/LGPL): 0
Unknown/NoAssertion licenses: 0
Top files with copyleft/unknown:

SBOM (SPDX)

Packages: 26
Copyleft package licenses (AGPL/GPL/LGPL): 0
Unknown/NoAssertion package licenses: 26

Copilot

Pull Request Overview

This PR implements a refactoring of the submit flow by splitting the metadata selection functionality into a separate component. It creates a dedicated metadata selector component for new datasets while keeping the existing submit component focused on file operations, improving code clarity and maintainability.

Split submit component into metadata selector and files-only submit components
Added new routing for metadata selector component with proper navigation state passing
Enhanced test coverage with comprehensive unit tests for both components

Reviewed Changes

Copilot reviewed 31 out of 35 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/app/metadata-selector/metadata-selector.component.ts	New component extracted from submit logic for metadata field selection
src/app/metadata-selector/metadata-selector.component.spec.ts	Comprehensive tests for the new metadata selector component
src/app/metadata-selector/metadata-selector.component.html	Template for metadata field selection interface
src/app/submit/submit.component.ts	Refactored to handle metadata from navigation state, removed inline metadata logic
src/app/submit/submit.component.spec.ts	Enhanced tests with proper mocking and additional test cases
src/app/submit/submit.component.html	Simplified template with metadata table section removed
src/app/compare/compare.component.ts	Updated routing logic to direct new datasets to metadata selector
src/app/app.routs.ts	Added route for the new metadata selector component
Various test files	Updated import formatting for consistency

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/app/submit/submit.component.ts

Copilot

Pull Request Overview

Copilot reviewed 31 out of 35 changed files in this pull request and generated 4 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/app/submit/submit.component.ts

src/app/metadata-selector/metadata-selector.component.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions · 2025-09-16T15:23:17Z

Code Review Agent (Python)\n

No Python files changed. Skipping analysis.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions · 2025-09-16T15:23:22Z

Code Review Agent (Python)\n

No Python files changed. Skipping analysis.

github-actions · 2025-09-16T15:23:29Z

Code Review Agent (Python)\n

No Python files changed. Skipping analysis.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions · 2025-09-16T15:23:48Z

Code Review Agent (Python)\n

No Python files changed. Skipping analysis.

ErykKul · 2025-09-16T15:28:45Z

Reset feature branch to main baseline and restored stable Submit.
Introduced metadata-selector component with Router state handoff to Submit.
Refactored Submit subscriptions for explicit cleanup; removed setTimeout patterns.
Added high-coverage unit tests for Submit and metadata-selector; CI green.
Fixed lint issues (one minor pre-existing warning remains).
Adjusted connect header layout (centered label, right-aligned action).
Rebased and synced branch; PR ready for review.

…er mocks

github-actions · 2025-09-16T15:32:56Z

Code Review Agent (Python)\n

No Python files changed. Skipping analysis.

Copilot

Pull Request Overview

Copilot reviewed 31 out of 35 changed files in this pull request and generated 5 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/app/submit/submit.component.ts

src/app/metadata-selector/metadata-selector.component.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions · 2025-09-16T15:36:02Z

Code Review Agent (Python)\n

No Python files changed. Skipping analysis.

github-actions · 2025-09-16T15:36:12Z

Code Review Agent (Python)\n

No Python files changed. Skipping analysis.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions · 2025-09-16T15:37:06Z

Code Review Agent (Python)\n

No Python files changed. Skipping analysis.

github-actions · 2025-09-16T15:37:13Z

Code Review Agent (Python)\n

No Python files changed. Skipping analysis.

ErykKul · 2025-09-16T15:38:53Z

/gov

github-actions · 2025-09-16T15:39:01Z

Governance Agent Report\n\n

PR: #54 by @ErykKul

Changed files (35):

angular.json
eslint.config.mjs
karma.conf.js
src/app/app.component.spec.ts
src/app/app.routs.ts
src/app/compare/compare.component.spec.ts
src/app/compare/compare.component.ts
src/app/compute/compute.component.spec.ts
src/app/compute/compute.component.ts
src/app/connect/connect.component.spec.ts
src/app/connect/connect.component.ts
src/app/data.service.spec.ts
src/app/datafile/datafile.component.spec.ts
src/app/datafile/datafile.component.ts
src/app/doi.lookup.service.spec.ts
src/app/download/download.component.spec.ts
src/app/download/download.component.ts
src/app/executablefile/executablefile.component.spec.ts
src/app/executablefile/executablefile.component.ts
src/app/metadata-selector/metadata-selector.component.html
src/app/metadata-selector/metadata-selector.component.scss
src/app/metadata-selector/metadata-selector.component.spec.ts
src/app/metadata-selector/metadata-selector.component.ts
src/app/oauth.service.spec.ts
src/app/plugin.service.spec.ts
src/app/repo.lookup.service.spec.ts
src/app/shared/constants.ts
src/app/shared/notification.service.ts
src/app/shared/types.ts
src/app/submit/submit.component.html
src/app/submit/submit.component.spec.ts
src/app/submit/submit.component.ts
src/app/submitted-file/submitted-file.component.ts
src/app/utils.service.ts
tests/governance/smoke.test.js

Detected change types:

userUI
backend

Missing or incomplete items:

Transparency notice updated
OWASP ASVS review or ASVS:

Tip: Use the PR template fields to satisfy these checks.

Run /gov help for commands. Also try: /gov links and /gov autofill apply.

github-actions · 2025-09-16T15:39:01Z

/gov copilot

github-actions · 2025-09-16T15:39:02Z

/gov links

github-actions · 2025-09-16T15:39:02Z

/gov autofill apply

github-actions · 2025-09-16T15:39:13Z

Governance reports summary

Run ID: 17771148570

ScanCode (licenses)

Copyleft findings (AGPL/GPL/LGPL): 0
Unknown/NoAssertion licenses: 0
Top files with copyleft/unknown:

SBOM (SPDX)

Packages: 26
Copyleft package licenses (AGPL/GPL/LGPL): 0
Unknown/NoAssertion package licenses: 26

Reapply "Refactor and enhance metadata handling in Submit and Metadat…

802e296

…aSelector components" This reverts commit 84b8af5.

ErykKul changed the title ~~temp: test~~ feat(ui): split submit into metadata selector + submit Sep 16, 2025

refactor(metadata-selector): remove unused dialog and checkbox compon…

2ecf728

…ents, streamline submit process

github-actions bot added ai-assisted asvs deployer security-review labels Sep 16, 2025

ErykKul added 2 commits September 16, 2025 15:59

test(submit): add focused unit tests for submit flow, data categoriza…

69ff4a7

…tion, and error handling; fix TDZ in subscriptions

refactor(submit): remove unused metadata display section from submit …

395a4f2

…component

ErykKul added 2 commits September 16, 2025 16:27

refactor(metadata-selector, submit): streamline metadata handling and…

89668d9

… remove unused code

fmt

365f3e7

ErykKul added 3 commits September 16, 2025 16:38

refactor(metadata-selector): update button labels for clarity and rem…

35ed84d

…ove unused 'done' property

refactor(metadata-selector): remove unused 'disabled' property and wa…

718fb6c

…rning icon

refactor(submit): update submit button style for consistency

e6f7034

ErykKul marked this pull request as ready for review September 16, 2025 15:01

ErykKul requested a review from Copilot September 16, 2025 15:01

Copilot AI reviewed Sep 16, 2025

View reviewed changes

src/app/submit/submit.component.ts Outdated Show resolved Hide resolved

src/app/submit/submit.component.ts Outdated Show resolved Hide resolved

src/app/submit/submit.component.ts Outdated Show resolved Hide resolved

Copilot AI reviewed Sep 16, 2025

View reviewed changes

ErykKul and others added 2 commits September 16, 2025 17:23

Update src/app/submit/submit.component.ts

6ecd40d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/app/submit/submit.component.ts

c2f2034

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/app/metadata-selector/metadata-selector.component.ts

aed175a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/app/metadata-selector/metadata-selector.component.ts

459e4ce

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix(submit): enhance navigation state handling with fallback for rout…

b6eda88

…er mocks

ErykKul requested a review from Copilot September 16, 2025 15:32

Copilot AI reviewed Sep 16, 2025

View reviewed changes

ErykKul and others added 2 commits September 16, 2025 17:35

Update src/app/submit/submit.component.ts

aa2f370

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/app/metadata-selector/metadata-selector.component.ts

97ed826

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

ErykKul and others added 2 commits September 16, 2025 17:36

Update src/app/metadata-selector/metadata-selector.component.ts

cc6fbe4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/app/metadata-selector/metadata-selector.component.ts

b5541b0

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

ErykKul merged commit 5d0497d into main Sep 16, 2025
14 checks passed

ErykKul deleted the feat/split-submit-metadata-selector branch February 13, 2026 17:41

Conversation

ErykKul commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

@AI-Tool: Copilot

Summary

AI Provenance (required for AI-assisted changes)

Compliance checklist

Change-type specifics

Tests & Risk

Uh oh!

github-actions bot commented Sep 16, 2025

Code Review Agent (Python)\n

Uh oh!

github-actions bot commented Sep 16, 2025

AI Governance checks failed

Uh oh!

github-actions bot commented Sep 16, 2025

Code Review Agent (Python)\n

Uh oh!

github-actions bot commented Sep 16, 2025

Code Review Agent (Python)\n

Uh oh!

github-actions bot commented Sep 16, 2025

Code Review Agent (Python)\n

Uh oh!

github-actions bot commented Sep 16, 2025

Code Review Agent (Python)\n

Uh oh!

github-actions bot commented Sep 16, 2025

Code Review Agent (Python)\n

Uh oh!

ErykKul commented Sep 16, 2025

Uh oh!

github-actions bot commented Sep 16, 2025

Governance Agent Report\n\n

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

github-actions bot commented Sep 16, 2025

Governance reports summary

ScanCode (licenses)

SBOM (SPDX)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 16, 2025

Code Review Agent (Python)\n

Uh oh!

github-actions bot commented Sep 16, 2025

Code Review Agent (Python)\n

Uh oh!

github-actions bot commented Sep 16, 2025

Code Review Agent (Python)\n

Uh oh!

github-actions bot commented Sep 16, 2025

Code Review Agent (Python)\n

Uh oh!

ErykKul commented Sep 16, 2025

Uh oh!

github-actions bot commented Sep 16, 2025

Code Review Agent (Python)\n

Uh oh!

ErykKul commented Sep 16, 2025 •

edited

Loading