Skip to content

Commit 92aa563

Browse files
authored
chore: using t.TempDir() instead of os.MkdirTemp (#3222)
1 parent 2e810f7 commit 92aa563

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

p2p/transport/quicreuse/tracer_test.go

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,6 @@ import (
1313
"github.com/stretchr/testify/require"
1414
)
1515

16-
func createLogDir(t *testing.T) string {
17-
dir, err := os.MkdirTemp("", "libp2p-quic-transport-test")
18-
require.NoError(t, err)
19-
t.Cleanup(func() { os.RemoveAll(dir) })
20-
return dir
21-
}
22-
2316
func getFile(t *testing.T, dir string) os.FileInfo {
2417
files, err := os.ReadDir(dir)
2518
require.NoError(t, err)
@@ -30,7 +23,7 @@ func getFile(t *testing.T, dir string) os.FileInfo {
3023
}
3124

3225
func TestSaveQlog(t *testing.T) {
33-
qlogDir := createLogDir(t)
26+
qlogDir := t.TempDir()
3427
logger := newQlogger(qlogDir, logging.PerspectiveServer, quic.ConnectionIDFromBytes([]byte{0xde, 0xad, 0xbe, 0xef}))
3528
file := getFile(t, qlogDir)
3629
require.Equal(t, ".", string(file.Name()[0]))
@@ -45,7 +38,7 @@ func TestSaveQlog(t *testing.T) {
4538
}
4639

4740
func TestQlogBuffering(t *testing.T) {
48-
qlogDir := createLogDir(t)
41+
qlogDir := t.TempDir()
4942
logger := newQlogger(qlogDir, logging.PerspectiveServer, quic.ConnectionIDFromBytes([]byte("connid")))
5043
initialSize := getFile(t, qlogDir).Size()
5144
// Do a small write.
@@ -60,7 +53,7 @@ func TestQlogBuffering(t *testing.T) {
6053
}
6154

6255
func TestQlogCompression(t *testing.T) {
63-
qlogDir := createLogDir(t)
56+
qlogDir := t.TempDir()
6457
logger := newQlogger(qlogDir, logging.PerspectiveServer, quic.ConnectionIDFromBytes([]byte("connid")))
6558
logger.Write([]byte("foobar"))
6659
require.NoError(t, logger.Close())

0 commit comments

Comments
 (0)