Skip to content

Conversation

@oblique
Copy link
Contributor

@oblique oblique commented Nov 3, 2025

Description

This removes a debug_assert from poll_flush because it can be valid for the user to recheck the flush state. In that case the operation should be noop.

A real life code that triggers this assertition is this.

Fixes #5618

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@oblique oblique changed the title fix(webtransport-websys): Remove poll_flush called after poll_close assertion fix(webtransport-websys): Allow poll_flush after poll_close Nov 3, 2025
@oblique oblique changed the title fix(webtransport-websys): Allow poll_flush after poll_close fix(webtransport-websys): Allow poll_flush after poll_close Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Closed stream is polled causing debug assertion to fail for WebTransport in wasm

2 participants