Skip to content

fix(webtransport-websys): Allow poll_flush after poll_close #6193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 12, 2025
+8 −7
Merged

fix(webtransport-websys): Allow poll_flush after poll_close #6193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1f3d7b0
fix(webtransport-websys): Remove `poll_flush called after poll_close`…
oblique Nov 3, 2025
44305bc
update changelog
oblique Nov 3, 2025
20945e1
Merge branch 'master' into fix/poll-flush-after-poll-close
jxs Nov 11, 2025
3235234
fix cargo.toml version
oblique Nov 11, 2025
c5ef6ac
fix workspace cargo.toml
oblique Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ libp2p-webrtc-utils = { version = "0.4.0", path = "misc/webrtc-utils" }
libp2p-webrtc-websys = { version = "0.4.0", path = "transports/webrtc-websys" }
libp2p-websocket = { version = "0.45.2", path = "transports/websocket" }
libp2p-websocket-websys = { version = "0.5.0", path = "transports/websocket-websys" }
libp2p-webtransport-websys = { version = "0.5.1", path = "transports/webtransport-websys" }
libp2p-webtransport-websys = { version = "0.5.2", path = "transports/webtransport-websys" }
libp2p-yamux = { version = "0.47.0", path = "muxers/yamux" }

# External dependencies
Expand Down
5 changes: 5 additions & 0 deletions transports/webtransport-websys/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 0.5.2

- Remove `poll_flush called after poll_close` assertion.
See [PR 6193](https://github.com/libp2p/rust-libp2p/pull/6193).

## 0.5.1

- Remove `once_cell` dependency.
Expand Down
2 changes: 1 addition & 1 deletion transports/webtransport-websys/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name = "libp2p-webtransport-websys"
edition.workspace = true
rust-version = { workspace = true }
description = "WebTransport for libp2p under WASM environment"
version = "0.5.1"
version = "0.5.2"
authors = [
"Yiannis Marangos <[email protected]>",
"oblique <[email protected]>",
Expand Down
4 changes: 0 additions & 4 deletions transports/webtransport-websys/src/stream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,10 +153,6 @@ impl StreamInner {
// messages were flushed.
self.poll_writer_ready(cx)
} else {
debug_assert!(
false,
"libp2p_webtransport_websys::Stream: poll_flush called after poll_close"
);
Poll::Ready(Ok(()))
}
}
Expand Down
Loading