Resolve lint warnings

Author: HexDecimal

tcod/bsp.py

@@ -27,14 +27,15 @@
 
 from __future__ import annotations
 
-from collections.abc import Iterator
 from typing import TYPE_CHECKING, Any
 
 from typing_extensions import deprecated
 
 from tcod.cffi import ffi, lib
 
 if TYPE_CHECKING:
+    from collections.abc import Iterator
+
     import tcod.random
 
 
@@ -125,7 +126,11 @@ def _unpack_bsp_tree(self, cdata: Any) -> None:  # noqa: ANN401
         self.children[1].parent = self
         self.children[1]._unpack_bsp_tree(lib.TCOD_bsp_right(cdata))
 
-    def split_once(self, horizontal: bool, position: int) -> None:
+    def split_once(
+        self,
+        horizontal: bool,  # noqa: FBT001
+        position: int,
+    ) -> None:
         """Split this partition into 2 sub-partitions.
 
         Args:
@@ -211,13 +216,13 @@ def level_order(self) -> Iterator[BSP]:
 
         .. versionadded:: 8.3
         """
-        next = [self]
-        while next:
-            level = next
-            next = []
+        next_ = [self]
+        while next_:
+            level = next_
+            next_ = []
             yield from level
             for node in level:
-                next.extend(node.children)
+                next_.extend(node.children)
 
     def inverted_level_order(self) -> Iterator[BSP]:
         """Iterate over this BSP's hierarchy in inverse level order.

tcod/random.py

@@ -12,14 +12,16 @@
 import os
 import random
 import warnings
-from collections.abc import Hashable
-from typing import Any
+from typing import TYPE_CHECKING, Any
 
 from typing_extensions import deprecated
 
 import tcod.constants
 from tcod.cffi import ffi, lib
 
+if TYPE_CHECKING:
+    from collections.abc import Hashable
+
 MERSENNE_TWISTER = tcod.constants.RNG_MT
 COMPLEMENTARY_MULTIPLY_WITH_CARRY = tcod.constants.RNG_CMWC
 MULTIPLY_WITH_CARRY = tcod.constants.RNG_CMWC

tests/test_tcod.py

@@ -18,14 +18,14 @@
 from tcod import libtcodpy
 
 
-def raise_Exception(*_args: object) -> NoReturn:
+def raise_exception(*_args: object) -> NoReturn:
     raise RuntimeError("testing exception")  # noqa: TRY003, EM101
 
 
 def test_line_error() -> None:
     """Test exception propagation."""
     with pytest.raises(RuntimeError), pytest.warns():
-        libtcodpy.line(0, 0, 10, 10, py_callback=raise_Exception)
+        libtcodpy.line(0, 0, 10, 10, py_callback=raise_exception)
 
 
 @pytest.mark.filterwarnings("ignore:Iterate over nodes using")
@@ -39,7 +39,7 @@ def test_tcod_bsp() -> None:
     assert not bsp.children
 
     with pytest.raises(RuntimeError):
-        libtcodpy.bsp_traverse_pre_order(bsp, raise_Exception)
+        libtcodpy.bsp_traverse_pre_order(bsp, raise_exception)
 
     bsp.split_recursive(3, 4, 4, 1, 1)
     for node in bsp.walk():
@@ -102,7 +102,7 @@ def test_tcod_map_pickle() -> None:
 def test_tcod_map_pickle_fortran() -> None:
     map_ = tcod.map.Map(2, 3, order="F")
     map2: tcod.map.Map = pickle.loads(pickle.dumps(copy.copy(map_)))
-    assert map_._Map__buffer.strides == map2._Map__buffer.strides  # type: ignore
+    assert map_._Map__buffer.strides == map2._Map__buffer.strides  # type: ignore[attr-defined]
     assert map_.transparent.strides == map2.transparent.strides
     assert map_.walkable.strides == map2.walkable.strides
     assert map_.fov.strides == map2.fov.strides
@@ -148,7 +148,7 @@ def test_path_numpy(dtype: DTypeLike) -> None:
         tcod.path.AStar(np.ones((2, 2), dtype=np.float64))
 
 
-def path_cost(this_x: int, this_y: int, dest_x: int, dest_y: int) -> bool:
+def path_cost(_this_x: int, _this_y: int, _dest_x: int, _dest_y: int) -> bool:
     return True
 
 
@@ -160,7 +160,7 @@ def test_path_callback() -> None:
 
 
 def test_key_repr() -> None:
-    Key = libtcodpy.Key
+    Key = libtcodpy.Key  # noqa: N806
     key = Key(vk=1, c=2, shift=True)
     assert key.vk == 1
     assert key.c == 2  # noqa: PLR2004
@@ -172,7 +172,7 @@ def test_key_repr() -> None:
 
 
 def test_mouse_repr() -> None:
-    Mouse = libtcodpy.Mouse
+    Mouse = libtcodpy.Mouse  # noqa: N806
     mouse = Mouse(x=1, lbutton=True)
     mouse_copy = eval(repr(mouse))  # noqa: S307
     assert mouse.x == mouse_copy.x
@@ -185,22 +185,22 @@ def test_cffi_structs() -> None:
 
 
 @pytest.mark.filterwarnings("ignore")
-def test_recommended_size(console: tcod.console.Console) -> None:
+def test_recommended_size(console: tcod.console.Console) -> None:  # noqa: ARG001
     tcod.console.recommended_size()
 
 
 @pytest.mark.filterwarnings("ignore")
-def test_context(uses_window: None) -> None:
+def test_context(uses_window: None) -> None:  # noqa: ARG001
     with tcod.context.new_window(32, 32, renderer=libtcodpy.RENDERER_SDL2):
         pass
-    WIDTH, HEIGHT = 16, 4
-    with tcod.context.new_terminal(columns=WIDTH, rows=HEIGHT, renderer=libtcodpy.RENDERER_SDL2) as context:
+    width, height = 16, 4
+    with tcod.context.new_terminal(columns=width, rows=height, renderer=libtcodpy.RENDERER_SDL2) as context:
         console = tcod.console.Console(*context.recommended_console_size())
         context.present(console)
         assert context.sdl_window_p is not None
         assert context.renderer_type >= 0
         context.change_tileset(tcod.tileset.Tileset(16, 16))
         context.pixel_to_tile(0, 0)
         context.pixel_to_subtile(0, 0)
-    with pytest.raises(RuntimeError, match=".*context has been closed"):
+    with pytest.raises(RuntimeError, match=r".*context has been closed"):
         context.present(console)