Skip to content

Commit 15a4acc

Browse files
coreymartinclaude
authored andcommitted
[js] Make @lightsparkdev/tsconfig publishable (#24477)
## Summary - Makes `@lightsparkdev/tsconfig` publishable: removes `"private": true`, adds `exports`/`files` fields, adds `publint`/`attw` package checks - Fixes the base.json resolution bug: removes `baseUrl`, `outDir`, `include`, `exclude` — these resolved relative to the config package directory, not the consumer workspace - Upgrades `ts-node` 10.9.1 → 10.9.2 (patch) to fix package-name tsconfig extends resolution ([TypeStrong/ts-node#2090](TypeStrong/ts-node#2090)) - Converts all 17 workspace tsconfig `extends` from relative paths to `@lightsparkdev/tsconfig/*` package paths - Adds missing `@lightsparkdev/tsconfig` devDependency to `nodejs-scripts` - Fixes pre-existing prettier issue in `SendWire.tsx` ## Test plan - [x] `yarn checks` — all 74 tasks pass (lint, format, test, circular-deps, gql-codegen, package:checks) - [x] `yarn build` — all 16 build tasks pass - [x] `yarn deps:check` (manypkg) passes - [x] `yarn workspace @lightsparkdev/tsconfig package:checks` passes (publint + attw) - [x] ts-node, Jest, and gql-codegen all resolve `@lightsparkdev/tsconfig/*` extends correctly 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> GitOrigin-RevId: dd8993dcfb2aa63c528ee55aec3c3df7672b9a81
1 parent ce84ce8 commit 15a4acc

File tree

24 files changed

+47
-45
lines changed

24 files changed

+47
-45
lines changed

.mise.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
MISE_NODE_COREPACK = true
33

44
[tools]
5-
node = "20"
5+
node = "latest"
66

77
[tasks.deps]
88
description = "Install all JS dependencies"

.nvmrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
v18

apps/examples/nodejs-scripts/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
"license": "ISC",
2121
"devDependencies": {
2222
"@lightsparkdev/eslint-config": "*",
23+
"@lightsparkdev/tsconfig": "0.0.1",
2324
"@types/jest": "^29.5.3",
2425
"@types/node": "^20.2.5",
2526
"eslint": "^8.3.0",
@@ -28,7 +29,7 @@
2829
"prettier": "3.0.3",
2930
"prettier-plugin-organize-imports": "^3.2.4",
3031
"ts-jest": "^29.1.1",
31-
"ts-node": "^10.9.1",
32+
"ts-node": "^10.9.2",
3233
"tsc-absolute": "^1.0.1",
3334
"typescript": "^5.6.2"
3435
},

apps/examples/nodejs-scripts/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"extends": "../../../packages/tsconfig/ts-node-app.json",
2+
"extends": "@lightsparkdev/tsconfig/ts-node-app.json",
33
"compilerOptions": {
44
"noEmit": true
55
},

apps/examples/oauth-app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
},
1717
"devDependencies": {
1818
"@lightsparkdev/eslint-config": "*",
19-
"@lightsparkdev/tsconfig": "*",
19+
"@lightsparkdev/tsconfig": "0.0.1",
2020
"@types/jest": "^29.5.3",
2121
"@types/node": "^20.2.5",
2222
"@types/react": "^18.2.12",

apps/examples/remote-signing-server/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"express": "^4.18.2"
2323
},
2424
"devDependencies": {
25-
"@lightsparkdev/tsconfig": "*",
25+
"@lightsparkdev/tsconfig": "0.0.1",
2626
"@types/jest": "^29.5.3",
2727
"@types/node": "^20.2.5",
2828
"@types/supertest": "^2.0.14",
@@ -34,7 +34,7 @@
3434
"prettier-plugin-organize-imports": "^3.2.4",
3535
"supertest": "^6.3.3",
3636
"ts-jest": "^29.1.1",
37-
"ts-node": "^10.9.1",
37+
"ts-node": "^10.9.2",
3838
"tsc-absolute": "^1.0.1",
3939
"typescript": "^5.6.2"
4040
},

apps/examples/remote-signing-server/server.test.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,9 @@
11
import { jest } from "@jest/globals";
22
import { LightsparkClient } from "@lightsparkdev/lightspark-sdk";
33
import supertest from "supertest";
4-
import { createRequire } from "node:module";
4+
import settings from "../settings.json" assert { type: "json" };
55
import { app } from "./src/index.js";
66

7-
const require = createRequire(import.meta.url);
8-
const settings = require("../settings.json") as {
9-
remoteSigningServer: { port: number };
10-
};
11-
127
describe("Test server routes", () => {
138
let server: ReturnType<typeof app.listen>;
149
let request = supertest(app);

apps/examples/remote-signing-server/src/startServer.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
1-
import { createRequire } from "node:module";
1+
import settings from "../../settings.json" assert { type: "json" };
22
import { app } from "./index.js";
33

4-
const require = createRequire(import.meta.url);
5-
const settings = require("../../settings.json") as {
6-
remoteSigningServer: { port: number };
7-
};
8-
94
app.listen(settings.remoteSigningServer.port, () => {
105
console.log(
116
`Server started on http://localhost:${settings.remoteSigningServer.port}`,

apps/examples/remote-signing-server/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"extends": "../../../packages/tsconfig/ts-node-app.json",
2+
"extends": "@lightsparkdev/tsconfig/ts-node-app.json",
33
"compilerOptions": {
44
"noEmit": true
55
}

apps/examples/ui-test-app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"@emotion/babel-plugin": "^11.11.0",
4141
"@emotion/jest": "^11.13.0",
4242
"@lightsparkdev/eslint-config": "*",
43-
"@lightsparkdev/tsconfig": "*",
43+
"@lightsparkdev/tsconfig": "0.0.1",
4444
"@lightsparkdev/vite": "*",
4545
"@testing-library/jest-dom": "^6.1.2",
4646
"@types/jest": "^29.5.3",

0 commit comments

Comments
 (0)