Skip to content

Commit 9be4cfa

Browse files
authored
Fix error message and error handling (#398)
NO-ISSUE Fix error message and error handling
1 parent b5a7629 commit 9be4cfa

File tree

4 files changed

+43
-16
lines changed

4 files changed

+43
-16
lines changed

src/tools/cancelRichMenuDefault.ts

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
22
import { messagingApi } from "@line/bot-sdk";
3-
import { createSuccessResponse } from "../common/response.js";
3+
import {
4+
createErrorResponse,
5+
createSuccessResponse,
6+
} from "../common/response.js";
47
import { AbstractTool } from "./AbstractTool.js";
58

69
export default class CancelRichMenuDefault extends AbstractTool {
@@ -22,8 +25,14 @@ export default class CancelRichMenuDefault extends AbstractTool {
2225
},
2326
},
2427
async () => {
25-
const response = await this.client.cancelDefaultRichMenu();
26-
return createSuccessResponse(response);
28+
try {
29+
const response = await this.client.cancelDefaultRichMenu();
30+
return createSuccessResponse(response);
31+
} catch (error) {
32+
return createErrorResponse(
33+
`Failed to cancel default rich menu: ${error.message}`,
34+
);
35+
}
2736
},
2837
);
2938
}

src/tools/getMessageQuota.ts

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
22
import { messagingApi } from "@line/bot-sdk";
3-
import { createSuccessResponse } from "../common/response.js";
3+
import {
4+
createErrorResponse,
5+
createSuccessResponse,
6+
} from "../common/response.js";
47
import { AbstractTool } from "./AbstractTool.js";
58

69
export default class GetMessageQuota extends AbstractTool {
@@ -23,14 +26,20 @@ export default class GetMessageQuota extends AbstractTool {
2326
},
2427
},
2528
async () => {
26-
const messageQuotaResponse = await this.client.getMessageQuota();
27-
const messageQuotaConsumptionResponse =
28-
await this.client.getMessageQuotaConsumption();
29-
const response = {
30-
limited: messageQuotaResponse.value,
31-
totalUsage: messageQuotaConsumptionResponse.totalUsage,
32-
};
33-
return createSuccessResponse(response);
29+
try {
30+
const messageQuotaResponse = await this.client.getMessageQuota();
31+
const messageQuotaConsumptionResponse =
32+
await this.client.getMessageQuotaConsumption();
33+
const response = {
34+
limited: messageQuotaResponse.value,
35+
totalUsage: messageQuotaConsumptionResponse.totalUsage,
36+
};
37+
return createSuccessResponse(response);
38+
} catch (error) {
39+
return createErrorResponse(
40+
`Failed to get message quota: ${error.message}`,
41+
);
42+
}
3443
},
3544
);
3645
}

src/tools/getRichMenuList.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export default class GetRichMenuList extends AbstractTool {
3131
return createSuccessResponse(response);
3232
} catch (error) {
3333
return createErrorResponse(
34-
`Failed to broadcast message: ${error.message}`,
34+
`Failed to get rich menu list: ${error.message}`,
3535
);
3636
}
3737
},

src/tools/setRichMenuDefault.ts

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
22
import { messagingApi } from "@line/bot-sdk";
3-
import { createSuccessResponse } from "../common/response.js";
3+
import {
4+
createErrorResponse,
5+
createSuccessResponse,
6+
} from "../common/response.js";
47
import { AbstractTool } from "./AbstractTool.js";
58
import { z } from "zod";
69

@@ -32,8 +35,14 @@ export default class SetRichMenuDefault extends AbstractTool {
3235
},
3336
},
3437
async ({ richMenuId }) => {
35-
const response = await this.client.setDefaultRichMenu(richMenuId);
36-
return createSuccessResponse(response);
38+
try {
39+
const response = await this.client.setDefaultRichMenu(richMenuId);
40+
return createSuccessResponse(response);
41+
} catch (error) {
42+
return createErrorResponse(
43+
`Failed to set default rich menu: ${error.message}`,
44+
);
45+
}
3746
},
3847
);
3948
}

0 commit comments

Comments
 (0)