Skip to content

Commit 0551526

Browse files
authored
xtask with Kompari (#1019)
This PR adds xtask similar to linebender/parley#272 for Parley. Because Vello has two types of tests: snapshots and comparisons (cpu vs. gpu), xtask is divided to two subcommands: ``` cargo xtask snapshots ... cargo xtask comparisons ... ``` The first one offers all Kompari's functionality (report, review, size-check, dead-snapshots detection). The second one offers only report as others do not make sense. Btw1: Current size check output: ![image](https://github.com/user-attachments/assets/3d51a8d1-9b7c-4a99-a0b0-c291a8f7588d) Btw2: Current dead snapshots report (This may be broken as some tests are skipped on my machine) ``` /home/ada/projects/vello/vello_tests/current/big_bitmap.png /home/ada/projects/vello/vello_tests/current/big_bitmap_apple.png /home/ada/projects/vello/vello_tests/current/big_colr.png /home/ada/projects/vello/vello_tests/current/bitmap_undef.png /home/ada/projects/vello/vello_tests/current/blurred_rounded_rect.png /home/ada/projects/vello/vello_tests/current/colr_undef.png /home/ada/projects/vello/vello_tests/current/deep_blend.png /home/ada/projects/vello/vello_tests/current/fill_types.png /home/ada/projects/vello/vello_tests/current/funky_paths.png /home/ada/projects/vello/vello_tests/current/gradient_extend.png /home/ada/projects/vello/vello_tests/current/image_extend_modes_bilinear.png /home/ada/projects/vello/vello_tests/current/image_extend_modes_nearest_neighbor.png /home/ada/projects/vello/vello_tests/current/image_sampling.png /home/ada/projects/vello/vello_tests/current/integer_translation.png /home/ada/projects/vello/vello_tests/current/little_bitmap.png /home/ada/projects/vello/vello_tests/current/little_colr.png /home/ada/projects/vello/vello_tests/current/longpathdash_butt.png /home/ada/projects/vello/vello_tests/current/many_clips.png /home/ada/projects/vello/vello_tests/current/non_integer_translation.png /home/ada/projects/vello/vello_tests/current/rounded_rectangle_watertight.png /home/ada/projects/vello/vello_tests/current/scaled_hinted.png /home/ada/projects/vello/vello_tests/current/simple_hinted.png /home/ada/projects/vello/vello_tests/current/smoke/data_image_roundtrip.png /home/ada/projects/vello/vello_tests/current/smoke/filled_circle.png /home/ada/projects/vello/vello_tests/current/smoke/filled_square.png /home/ada/projects/vello/vello_tests/current/smoke/two_emoji.png /home/ada/projects/vello/vello_tests/current/splash.png /home/ada/projects/vello/vello_tests/current/stroke_styles.png /home/ada/projects/vello/vello_tests/current/stroke_styles_non_uniform.png /home/ada/projects/vello/vello_tests/current/stroke_styles_skew.png /home/ada/projects/vello/vello_tests/current/tricky_strokes.png ```
1 parent 4d705c7 commit 0551526

File tree

8 files changed

+702
-3
lines changed

8 files changed

+702
-3
lines changed

.cargo/config.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,4 @@ run_wasm = "run --release --package run_wasm --"
66
# Other crates use the alias run-wasm, even though crate names should use `_`s not `-`s
77
# Allow this to be used
88
run-wasm = "run_wasm"
9+
xtask = "run --release --package xtask --"

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ env:
1919
FEATURES_DEPENDING_ON_STD: "std,default,png,pico_svg,multithreading"
2020
# List of packages that can not target Wasm.
2121
# `vello_tests` uses `nv-flip`, which doesn't support Wasm.
22-
NO_WASM_PKGS: "--exclude vello_tests"
22+
NO_WASM_PKGS: "--exclude vello_tests --exclude xtask"
2323
# The files stored in LFS the tests need to access, in JSON format
2424
LFS_FILES: '["vello_tests/snapshots/*.png", "sparse_strips/vello_sparse_tests/snapshots/*.png"]'
2525

0 commit comments

Comments
 (0)