fix: broken object storage wizard when cluster name is not of type string (#889)

* fix: extra string check if input is not of type string

* fix: test

* fix: better check

* fix: test description

---------

Co-authored-by: svcAPLBot <174728082+svcAPLBot@users.noreply.github.com>

Author: ElderMatt

src/utils/wizardUtils.test.ts

@@ -107,6 +107,13 @@ describe('ObjectStorageClient', () => {
       expect(clusterId).toBe('123')
     })
 
+    test('should return 123 when clusterId is a number', () => {
+      const settings = { cluster: { name: 123 } }
+      clusterId = defineClusterId(settings.cluster.name)
+
+      expect(clusterId).toBe('123')
+    })
+
     test('should return undefined when cluster name is undefined', () => {
       const settings: any = { cluster: {} }
       clusterId = defineClusterId(settings.cluster?.name)

src/utils/wizardUtils.ts

@@ -57,7 +57,8 @@ export class ObjectStorageClient {
   }
 }
 // define cluster id based on cluster name
-export function defineClusterId(clusterName: string | undefined): string | undefined {
+export function defineClusterId(clusterName: string | number | undefined): string | undefined {
   if (!clusterName) return undefined
-  return clusterName.replace('aplinstall', '')
+  const clusterNameStr = String(clusterName)
+  return clusterNameStr.replace('aplinstall', '')
 }