Support increased block storage volume limits

Author: ezilber-akamai

linode_api4/objects/linode.py

@@ -39,7 +39,7 @@
 from linode_api4.objects.serializable import JSONObject, StrEnum
 from linode_api4.objects.vpc import VPC, VPCSubnet
 from linode_api4.paginated_list import PaginatedList
-from linode_api4.util import drop_null_keys
+from linode_api4.util import drop_null_keys, generate_device_suffixes
 
 PASSWORD_CHARS = string.ascii_letters + string.digits + string.punctuation
 
@@ -1258,9 +1258,11 @@ def config_create(
         from .volume import Volume  # pylint: disable=import-outside-toplevel
 
         hypervisor_prefix = "sd" if self.hypervisor == "kvm" else "xvd"
-        device_names = [
-            hypervisor_prefix + string.ascii_lowercase[i] for i in range(0, 8)
-        ]
+
+        device_limit = int(max(8, min(self.specs.memory // 1024, 64)))
+
+        device_names = [hypervisor_prefix + suffix for suffix in generate_device_suffixes(device_limit)]
+
         device_map = {
             device_names[i]: None for i in range(0, len(device_names))
         }

linode_api4/util.py

@@ -3,6 +3,7 @@
 """
 
 from typing import Any, Dict
+import string
 
 
 def drop_null_keys(data: Dict[Any, Any], recursive=True) -> Dict[Any, Any]:
@@ -27,3 +28,28 @@ def recursive_helper(value: Any) -> Any:
         return value
 
     return recursive_helper(data)
+
+
+def generate_device_suffixes(n):
+    """
+    Generate n alphabetical suffixes starting with a, b, c, etc.
+    After z, continue with aa, ab, ac, etc. followed by aaa, aab, etc.
+    Example:
+        generate_device_suffixes(30) ->
+        ['a', 'b', 'c', ..., 'z', 'aa', 'ab', 'ac', 'ad']
+    """
+    letters = string.ascii_lowercase
+    result = []
+    i = 0
+
+    while len(result) < n:
+        s = ""
+        x = i
+        while True:
+            s = letters[x % 26] + s
+            x = x // 26 - 1
+            if x < 0:
+                break
+        result.append(s)
+        i += 1
+    return result

test/unit/util_test.py

@@ -1,6 +1,6 @@
 import unittest
 
-from linode_api4.util import drop_null_keys
+from linode_api4.util import drop_null_keys, generate_device_suffixes
 
 
 class UtilTest(unittest.TestCase):
@@ -53,3 +53,21 @@ def test_drop_null_keys_recursive(self):
         }
 
         assert drop_null_keys(value) == expected_output
+
+    def test_generate_device_suffixes(self):
+        """
+        Tests whether generate_device_suffixes works as expected.
+        """
+
+        expected_output_12 = ["a", "b", "c", "d", "e", "f", "g", "h", "i", "j", "k", "l"]
+        assert generate_device_suffixes(12) == expected_output_12
+
+        expected_output_30 = ["a", "b", "c", "d", "e", "f", "g", "h", "i", "j", "k", "l", "m", "n", "o", "p", "q", "r",
+                              "s", "t", "u", "v", "w", "x", "y", "z", "aa", "ab", "ac", "ad"]
+        assert generate_device_suffixes(30) == expected_output_30
+
+        expected_output_60 = ["a", "b", "c", "d", "e", "f", "g", "h", "i", "j", "k", "l", "m", "n", "o", "p", "q", "r",
+                              "s", "t", "u", "v", "w", "x", "y", "z", "aa", "ab", "ac", "ad", "ae", "af", "ag", "ah",
+                              "ai", "aj", "ak", "al", "am", "an", "ao", "ap", "aq", "ar", "as", "at", "au", "av", "aw",
+                              "ax", "ay", "az", "ba", "bb", "bc", "bd", "be", "bf", "bg", "bh"]
+        assert generate_device_suffixes(60) == expected_output_60