gpaste-reloaded: add option to reverse history order (fixes #8042)

remove redundant comments

Author: hthienloc

gpaste-reloaded@feuerfuchs.eu/README.md

@@ -6,6 +6,7 @@ This is a completely re-written GPaste applet based on the [gnome shell extensio
 * Support for multiple histories
 * Manually add entries to the history
 * Unlimited instances
+* Option to reverse the history order so that new items appear at the bottom of the menu
 
 
 # Installation

gpaste-reloaded@feuerfuchs.eu/files/gpaste-reloaded@feuerfuchs.eu/6.4/applet.js

@@ -146,6 +146,7 @@ class GPasteApplet extends Applet.IconApplet {
             this._appletSettings.bind("display-searchbar",     "displaySearchBar",    this._onDisplaySettingsUpdated);
             this._appletSettings.bind("display-gpaste-ui",     "displayGPasteUI",     this._onDisplaySettingsUpdated);
             this._appletSettings.bind("display-empty-history", "displayEmptyHistory", this._onDisplaySettingsUpdated);
+            this._appletSettings.bind("reverse-history-order", "reverseHistory", this._onDisplaySettingsUpdated);
 
             this._appletSettings.bind("kb-show-history", "kbShowHistory", this._onKeybindingUpdated);
             this._onKeybindingUpdated();
@@ -254,6 +255,9 @@ class GPasteApplet extends Applet.IconApplet {
 
         this.msepBottom2.actor.visible       = this.displayGPasteUI;
         this.mitemUI.actor.visible           = this.displayGPasteUI;
+
+        // any change to these settings may require re-rendering the history
+        this._onSettingsUpdated();
     }
 
     /*
@@ -273,10 +277,6 @@ class GPasteApplet extends Applet.IconApplet {
             }
         }
 
-        if (this.mitemSearch.entry.get_text() == '') {
-            this._historyItems[0].actor.set_style("font-weight: bold;");
-        }
-
         this.refresh(oldSize);
     }
 
@@ -352,6 +352,9 @@ class GPasteApplet extends Applet.IconApplet {
      * Refresh the history items
      */
     refresh (startID) {
+        // clear any previous styling before we repopulate
+        this._historyItems.forEach(item => item.actor.set_style(null));
+
         if (this._searchResults.length > 0) { // Search field isn't empty
             this.search(this.mitemSearch.getText());
         } else {
@@ -364,7 +367,9 @@ class GPasteApplet extends Applet.IconApplet {
                 }
 
                 for (let i = startID; i < size; ++i) {
-                    this._historyItems[i].setIndex(i);
+                    // if reverseHistory is enabled we flip the index we ask for
+                    const idx = this.reverseHistory ? (size - 1 - i) : i;
+                    this._historyItems[i].setIndex(idx);
                 }
                 for (let i = size; i < maxSize; ++i) {
                     this._historyItems[i].setIndex(-1);
@@ -374,6 +379,10 @@ class GPasteApplet extends Applet.IconApplet {
                     this.mitemHistoryIsEmpty.actor.show();
                 } else {
                     this.mitemHistoryIsEmpty.actor.hide();
+                    // highlight the item that corresponds to the newest element
+                    const highlightPos = this.reverseHistory ? size - 1 : 0;
+                    if (highlightPos >= 0 && highlightPos < this._historyItems.length)
+                        this._historyItems[highlightPos].actor.set_style("font-weight: bold;");
                 }
             });
         }
@@ -397,14 +406,18 @@ class GPasteApplet extends Applet.IconApplet {
                     results = maxSize;
                 }
 
+                // if we're showing results in reverse order we should flip the array
+                const ordered = this.reverseHistory ? this._searchResults.slice().reverse() : this._searchResults;
+
                 this._historyItems.slice(0, results).forEach((item, index) => {
-                    item.setUuid(this._searchResults[index]);
+                    item.setUuid(ordered[index]);
                 });
                 this._historyItems.slice(results, maxSize).forEach((item, index) => {
                     item.setIndex(-1);
                 });
 
-                this._historyItems[0].actor.set_style(null);
+                // clear styling from all items when searching
+                this._historyItems.forEach(item => item.actor.set_style(null));
 
                 if (results == 0) { // There aren't any results, display "(No results)"
                     this.mitemNoSearchResults.actor.show();
@@ -417,7 +430,6 @@ class GPasteApplet extends Applet.IconApplet {
 
             this._searchResults = [];
             this.refresh(0);
-            this._historyItems[0].actor.set_style("font-weight: bold;");
         }
     }
 
@@ -572,6 +584,17 @@ class GPasteApplet extends Applet.IconApplet {
         this.mitemTrack.setToggleState(state);
     }
 
+    /*
+     * Called whenever settings change that affect how the history is presented
+     */
+    _onSettingsUpdated() {
+        if (this._searchResults.length > 0) {
+            this.search(this.mitemSearch.getText());
+        } else {
+            this.refresh(0);
+        }
+    }
+
     //
     // Overrides
     // ---------------------------------------------------------------------------------

gpaste-reloaded@feuerfuchs.eu/files/gpaste-reloaded@feuerfuchs.eu/6.4/settings-schema.json

@@ -33,6 +33,11 @@
         "type":        "checkbox",
         "description": "Display 'Empty history'"
     },
+    "reverse-history-order": {
+        "default":     false,
+        "type":        "checkbox",
+        "description": "Reverse history order (newest at bottom)"
+    },
 
     "key-bindings": {
         "type":        "header",