Skip to content

Commit 3374738

Browse files
authored
Merge pull request #105 from lisc-tools/contrib
[MNT] - Update contributing & changelog
2 parents 0defbb7 + 94b37be commit 3374738

3 files changed

Lines changed: 20 additions & 43 deletions

File tree

CONTRIBUTING.md

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ We welcome any contributions to the project that extend or improve code and/or d
77
This page includes information for how to get involved and contribute to the project, and guidelines for how to do so.
88

99
This project adheres to a
10-
[code of conduct](https://github.com/lisc-tools/liscp/blob/main/CODE_OF_CONDUCT.md)
10+
[code of conduct](https://github.com/lisc-tools/lisc/blob/main/CODE_OF_CONDUCT.md)
1111
that you are expected to uphold when participating in this project.
1212

1313
On this page, you can find information on:
@@ -20,7 +20,8 @@ On this page, you can find information on:
2020

2121
## Reporting a Problem
2222

23-
To report an issue with the code, please submit it to our [issue tracker](https://github.com/lisc-tools/lisc/issues).
23+
To report an issue with the code, please submit it to our
24+
[issue tracker](https://github.com/lisc-tools/lisc/issues).
2425

2526
In doing so, please try to include the following:
2627

@@ -49,7 +50,8 @@ If you have a new idea you would like to suggest or contribute, please do the fo
4950
If you are interested in getting involved and helping with the project, a great place to start is to visit the
5051
[issues](https://github.com/lisc-tools/lisc/issues) or
5152
[development](https://github.com/lisc-tools/Development) page
52-
and see if there is anything you would be interested in helping with. If so, join the conversation, and project developers can help get you started.
53+
and see if there is anything you would be interested in helping with.
54+
If so, join the conversation, and project developers can help get you started.
5355

5456
## Project Scope
5557

@@ -62,18 +64,17 @@ such as custom or custom web scraping and/or novel natural language processing (
6264

6365
## Making a Contribution
6466

65-
If there is a feature you would like to add, or an issue you saw that you think you can help with, you are ready to make a submission to the project!
67+
If there is a feature you would like to add, or an issue you saw that you think you can help with, you are ready to make a submission to the project! If you are working on a feature, please indicate so in the relevant issue, so that we can keep track of who is working on what.
6668

67-
If you are working on a feature, please indicate so in the relevant issue, so that we can keep track of who is working on what.
69+
All contributions are managed through Github.
70+
If you are ready to start working on a contribution, you should follow the Github
71+
[guidelines for contributing to a project](https://docs.github.com/en/get-started/exploring-projects-on-github/contributing-to-a-project), which include forking the repository, making your suggested changes to the code, and then opening a pull request (PR) to suggest the code to the project.
6872

69-
Once you're ready to start working on your contribution, do the following:
73+
Once you open a PR, developers will review the code. Please make sure to check and follow the
74+
[project conventions](#project-conventions) so that all new or updated code follows the guidelines.
7075

71-
1. [Fork this repository](https://help.github.com/articles/fork-a-repo/), which makes your own version of this project you can edit
72-
2. [Make your changes](https://guides.github.com/activities/forking/#making-changes), updating or adding code to add the desired functionality
73-
3. [Check the project conventions](#project-conventions), and make sure all new or updated code follows the guidelines
74-
4. [Submit a pull request](https://help.github.com/articles/proposing-changes-to-a-project-with-pull-requests/), to start the process of merging the new code to the main branch
75-
76-
If it's your first time contributing to open source software, check out this free resource on [how to contribute to an open-source project on GitHub](https://app.egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github).
76+
If it's your first time contributing to open source software, check out this free resource on
77+
[how to contribute to open-source projects on GitHub](https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github).
7778

7879
## Project Conventions
7980

@@ -120,9 +121,7 @@ All code contributed to the module should follow these conventions:
120121
* Any new functionality should be added and described in the tutorials and/or examples
121122
* If a new approach is added, a new tutorial or example may be appropriate
122123
* To build and check the documentation locally:
123-
* Install the requirements for the docsite (`pip install -r requirements-doc.txt`)
124+
* Install the requirements for the docsite (`pip install -r requirements-docs.txt`)
124125
* Move to the `lisc/doc` directory (`cd doc`)
125126
* Run `make html` to create a local copy of the documentation website
126127
* The documentation can then be opened in a web browser by opening the file `lisc/doc/_build/html/index.html`
127-
128-
For more guidelines on how to write well formated and organized code, check out the [Python API Checklist](http://python.apichecklist.com).

doc/changelog.rst

Lines changed: 5 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,14 @@
11
Code Changelog
22
==============
33

4-
This page contains the changelog for the `lisc` module and any notes on updating between versions.
4+
This page contains the changelog for the `lisc` module.
55

6-
Notes on the specific updates related to each release are also available on the
6+
This page primarily notes changes for major version updates, as well as any notes on updating between versions. For notes on the specific updates included within minor releases, see the
77
`release page <https://github.com/lisc-tools/lisc/releases>`_.
88

99
Note that between release versions, the general code API should stay consistent, so code from previous releases should generally be compatible with this release. However, internal objects and functions may change, such that saving / loading objects and processing already collected data may be slightly different. It is generally recommended that data be collected and processed within the same version of the module. If you need to load / process data from a different release version, you may need to check if the processing works, and update some things to make it work.
1010

11-
0.2.X
12-
-----
11+
0.X.X Series
12+
------------
1313

14-
The 0.2.X series is the current release series of the module.
15-
16-
This series is a non-breaking update on the prior release.
17-
18-
The main updates in this update include:
19-
- Internal updates to the LISC objects, and processing (including PRs #36, #39, #50, #60, #67, #68)
20-
- Internal updates to the collection procedures (including PRs #49, #53, #61)
21-
- Updates to available plotting utilities and saving (including PRs #41, #54, #66)
22-
- Extended Pubmed collection to use additional settings, including setting date ranges (including PR #44)
23-
- Add OpenCitations option to collect DOIs of citing papers (including PR #27)
24-
- Miscellaneous bug fixes (including PRs #62, #69)
25-
- General documentation updates (including PRs #30, #31, #38, #43, #45, #46, #64)
26-
27-
0.1.X
28-
-----
29-
30-
The 0.1.X series was the initial release series of the module.
14+
The 0.X.X series, starting with 0.1.0 and currently ongoing is the initial major version and release series of the module.

requirements-docs.txt

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,4 @@ sphinx
33
sphinx_gallery
44
sphinx_bootstrap_theme
55
sphinx-copybutton
6-
numpydoc
7-
8-
# Optional dependencies that are required for building documentation
9-
matplotlib
10-
seaborn
11-
scipy
12-
wordcloud
6+
numpydoc

0 commit comments

Comments
 (0)