Skip to content

Commit cd762d0

Browse files
framework/app: remove unused aliases (#224)
* framework/app: remove unused aliases * framework/view,controller: remove unused code
1 parent 49ef00e commit cd762d0

File tree

4 files changed

+4
-15
lines changed

4 files changed

+4
-15
lines changed

framework/app/loader.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,7 @@ func (l *loader) loadProvider() *di.Provider {
6767
di.ToType(l.module.Import("bud/internal/app/web"), "*Server"),
6868
&di.Error{},
6969
},
70-
Aliases: di.Aliases{
71-
di.ToType("io/fs", "FS"): di.ToType("github.com/livebud/bud/package/overlay", "*FileSystem"),
72-
jsVM: di.ToType("github.com/livebud/bud/package/js/v8client", "*Client"),
73-
di.ToType("github.com/livebud/bud/runtime/view", "Renderer"): di.ToType("github.com/livebud/bud/runtime/view", "*Server"),
74-
},
70+
Aliases: di.Aliases{},
7571
}
7672
if l.flag.Embed {
7773
fn.Aliases[jsVM] = di.ToType("github.com/livebud/bud/package/js/v8", "*VM")

framework/controller/loader.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -533,9 +533,7 @@ func (l *loader) loadProvider(controller *Controller, method *parser.Function) *
533533
{Import: "net/http", Type: "*Request"},
534534
{Import: "net/http", Type: "ResponseWriter"},
535535
},
536-
Aliases: di.Aliases{
537-
di.ToType("github.com/livebud/bud/runtime/view", "Renderer"): di.ToType("github.com/livebud/bud/runtime/view", "*Server"),
538-
},
536+
Aliases: di.Aliases{},
539537
})
540538
if err != nil {
541539
l.Bail(err)

framework/view/viewrt/viewrt.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,6 @@ import (
1212
"github.com/livebud/bud/package/js"
1313
)
1414

15-
// Renderer interface
16-
type Renderer interface {
17-
Render(path string, props interface{}) (*ssr.Response, error)
18-
}
19-
2015
type Server interface {
2116
Middleware(http.Handler) http.Handler
2217
Handler(route string, props interface{}) http.Handler

scripts/test-watcher/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ func run(ctx context.Context) error {
1818
return err
1919
}
2020
ctx = sig.Trap(ctx, os.Interrupt)
21-
return watcher.Watch(ctx, dirname, func(paths []string) error {
22-
fmt.Println("-> triggered", paths)
21+
return watcher.Watch(ctx, dirname, func(events []watcher.Event) error {
22+
fmt.Println("-> triggered", events)
2323
return nil
2424
})
2525
}

0 commit comments

Comments
 (0)