fix: make provider_id a required field in vector DB registration

Author: HabebNawatha

llama_stack/apis/vector_dbs/vector_dbs.py

@@ -90,8 +90,8 @@ async def register_vector_db(
         self,
         vector_db_id: str,
         embedding_model: str,
+        provider_id: str,
         embedding_dimension: int | None = 384,
-        provider_id: str | None = None,
         vector_db_name: str | None = None,
         provider_vector_db_id: str | None = None,
     ) -> VectorDB:

llama_stack/core/routing_tables/vector_dbs.py

@@ -47,21 +47,12 @@ async def register_vector_db(
         self,
         vector_db_id: str,
         embedding_model: str,
+        provider_id: str,
         embedding_dimension: int | None = 384,
-        provider_id: str | None = None,
         provider_vector_db_id: str | None = None,
         vector_db_name: str | None = None,
     ) -> VectorDB:
         provider_vector_db_id = provider_vector_db_id or vector_db_id
-        if provider_id is None:
-            if len(self.impls_by_provider_id) > 0:
-                provider_id = list(self.impls_by_provider_id.keys())[0]
-                if len(self.impls_by_provider_id) > 1:
-                    logger.warning(
-                        f"No provider specified and multiple providers available. Arbitrarily selected the first provider {provider_id}."
-                    )
-            else:
-                raise ValueError("No provider available. Please configure a vector_io provider.")
         model = await lookup_model(self, embedding_model)
         if model is None:
             raise ModelNotFoundError(embedding_model)