Skip to content

Commit b329f4b

Browse files
chore: Enable keyword search for Milvus inline
Signed-off-by: Varsha Prasad Narsing <[email protected]>
1 parent 8031141 commit b329f4b

File tree

4 files changed

+8
-10
lines changed

4 files changed

+8
-10
lines changed

llama_stack/providers/remote/vector_io/milvus/milvus.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -409,15 +409,6 @@ async def query_chunks(
409409
index = await self._get_and_cache_vector_db_index(vector_db_id)
410410
if not index:
411411
raise VectorStoreNotFoundError(vector_db_id)
412-
413-
if params and params.get("mode") == "keyword":
414-
# Check if this is inline Milvus (Milvus-Lite)
415-
if hasattr(self.config, "db_path"):
416-
raise NotImplementedError(
417-
"Keyword search is not supported in Milvus-Lite. "
418-
"Please use a remote Milvus server for keyword search functionality."
419-
)
420-
421412
return await index.query_chunks(query, params)
422413

423414
async def delete_chunks(self, store_id: str, chunk_ids: list[str]) -> None:

pyproject.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ unit = [
9393
"blobfile",
9494
"faiss-cpu",
9595
"pymilvus>=2.5.12",
96+
"milvus-lite>=2.5.0",
9697
"litellm",
9798
"together",
9899
"coverage",
@@ -118,6 +119,7 @@ test = [
118119
"sqlalchemy[asyncio]>=2.0.41",
119120
"requests",
120121
"pymilvus>=2.5.12",
122+
"milvus-lite>=2.5.0",
121123
"weaviate-client>=4.16.4",
122124
]
123125
docs = [

tests/integration/vector_io/test_openai_vector_stores.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ def skip_if_provider_doesnt_support_openai_vector_stores_search(client_with_mode
5555
"keyword": [
5656
"inline::sqlite-vec",
5757
"remote::milvus",
58+
"inline::milvus",
5859
],
5960
"hybrid": [
6061
"inline::sqlite-vec",

uv.lock

Lines changed: 5 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)