fix: use string annotations for S3Client type hints

[derekhiggins]

fix: use string annotations for S3Client type hints

Remove future annotations import and use quoted string annotations for S3Client to avoid import issues.

Changes:
o Remove __future__ annotations import
o Use "S3Client" string annotations in type hints

closes: #4241

[mattf]

we should avoid eval_str=True

s3/files.py uses future annotations while localfs/files.py does not.

do we need import __future__ import annotations for the s3 provider?

[derekhiggins]

we should avoid eval_str=True

s3/files.py uses future annotations while localfs/files.py does not.

do we need import __future__ import annotations for the s3 provider?

It seems like the import is there to allow mypy_boto3_s3 to be a dependency only when doing
type checking but not be a runtime dependency,

There are 2 alternative I can think of

1. Remove __future__ import, use quoted strings (e.g. https://gist.github.com/derekhiggins/57e951803d42a6dab60c34521d1f2c53 )

2. Add mypy_boto3_s3 as a run time dependency of the s3 provider, which will allow us to remove the TYPE_CHECKING check and the futures import

[mattf]

we should avoid eval_str=True
s3/files.py uses future annotations while localfs/files.py does not.
do we need import __future__ import annotations for the s3 provider?

It seems like the import is there to allow mypy_boto3_s3 to be a dependency only when doing type checking but not be a runtime dependency,

There are 2 alternative I can think of

1. Remove `__future__` import, use quoted strings (e.g. https://gist.github.com/derekhiggins/57e951803d42a6dab60c34521d1f2c53 )

2. Add mypy_boto3_s3 as a run time dependency of the s3 provider, which will allow us to remove the `TYPE_CHECKING` check and the **futures** import

i'm good with (1) if you are

[derekhiggins]

i'm good with (1) if you are

works for me, PR updated, thanks

[mattf]

lgtm

[ashwinb]

lg