Skip to content

Conversation

@odashi
Copy link
Member

@odashi odashi commented Aug 27, 2025

本質は同じですが多少の挙動の変更を行いました。特に重要なのは:

  • TRAIN_ITERSの削除
  • 起動スクリプトの引数にwalltimeを追加

@odashi odashi requested review from reiyw and so298 August 27, 2025 19:33
@odashi
Copy link
Member Author

odashi commented Aug 29, 2025

@reiyw ping

reiyw
reiyw previously approved these changes Aug 29, 2025
@so298
Copy link
Contributor

so298 commented Aug 29, 2025

ありがとうございます。良い感じだと思います

ついでに

--overlap-grad-reduce
--overlap-param-gather

もデフォルトでオプションに追加しておくのはどうでしょうか?

so298
so298 previously approved these changes Aug 29, 2025
@odashi odashi dismissed stale reviews from so298 and reiyw via 7f985cf December 8, 2025 05:29
@odashi odashi requested a review from reiyw December 8, 2025 05:30
@odashi
Copy link
Member Author

odashi commented Dec 8, 2025

#95 (comment)

@so298 少し間が空きました。上記のオプションは事前の実験で効果が見られなかったので、参考程度にコメントで残しておくに留めてあります。デフォルトではオフのままにしようと思います。

@odashi odashi merged commit d8a675b into main Dec 8, 2025
@odashi odashi deleted the simplify-v4up branch December 8, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants