Inconsistent behavior for envoy.get between Erlang and JS targets

[mooreryan]

Expected return value according to type annotations is Result(String, Nil)

envoy/src/envoy.gleam

Line 17 in e3c80dd

pub fn get(name: String) -> Result(String, Nil)

Erlang matches that:

envoy/src/envoy_ffi.erl

Line 7 in e3c80dd

false -> {error, nil};

JS has a string value rather than nil:

envoy/src/envoy_ffi.mjs

Line 14 in e3c80dd

return new GError("Key not found");

Neither one is favored in the tests as they both use the _ match:

envoy/test/envoy_test.gleam

Line 12 in e3c80dd

let assert Error(_) = envoy.get("UAGE")

envoy/test/envoy_test.gleam

Line 20 in e3c80dd

let assert Error(_) = envoy.get("UAGE")

The Result(String, Nil) is probably the desired behavior as it matches dict.get:

https://github.com/gleam-lang/stdlib/blob/341a71049ad765f8788af497969efbb94aba0bab/src/gleam/dict.gleam#L152-L152

What do you think?

(Related to the test failure on the gleam cookbook: gleam-lang/cookbook#20)

[lpil]

Oh how awful, I'm sorry about this!