DM-54211: Change event field names to use backend-specific prefix#236
Merged
DM-54211: Change event field names to use backend-specific prefix#236
Conversation
stvoutsin
commented
Feb 20, 2026
| result.update(self.status.to_logging_context()) | ||
| if self.status.collected_bytes: | ||
| result["backend_size"] = self.status.collected_bytes | ||
| match self.status.backend_type: |
Member
Author
There was a problem hiding this comment.
I could also shorten this with an f-string, but felt this was more readable. Alternative would be:
backend_prefix = self.status.backend_type.lower()
result[f"{backend_prefix}_size"] = self.status.collected_bytes
Member
There was a problem hiding this comment.
I like the match better -- I agree that it's easier to read.
rra
approved these changes
Feb 20, 2026
| result.update(self.status.to_logging_context()) | ||
| if self.status.collected_bytes: | ||
| result["backend_size"] = self.status.collected_bytes | ||
| match self.status.backend_type: |
Member
There was a problem hiding this comment.
I like the match better -- I agree that it's easier to read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on team discussion we decided that we want each backend to submit an event with field names that include the backend prefix. In other words,
bigquery_elapsed,qserv_elapsedinstead ofbackend_elapsed