Merge pull request #107 from bengriffin1/bengriffin1-post-header-bugfix

[FIX]: adding json header

Author: bengriffin1

src/modules/nft/index.ts

@@ -17,7 +17,9 @@ export class NFTModule extends BaseModule {
       quantity,
       destination_address: destinationAddress,
     };
-    const response = await post(`${this.sdk.apiBaseUrl}${v1StartMint721Path}`, this.sdk.secretApiKey, body);
+    const response = await post(`${this.sdk.apiBaseUrl}${v1StartMint721Path}`, this.sdk.secretApiKey, body, {
+      'Content-Type': 'application/json',
+    });
     if (!isMintRequest(response) || response.status !== successStatus) throw mintingError();
     const request: MintRequest = response;
     return request;
@@ -36,7 +38,9 @@ export class NFTModule extends BaseModule {
       destination_address: destinationAddress,
       token_id: tokenId,
     };
-    const response = await post(`${this.sdk.apiBaseUrl}${v1StartMint1155Path}`, this.sdk.secretApiKey, body);
+    const response = await post(`${this.sdk.apiBaseUrl}${v1StartMint1155Path}`, this.sdk.secretApiKey, body, {
+      'Content-Type': 'application/json',
+    });
     if (!isMintRequest(response) || response.status !== successStatus) throw mintingError();
     const request: MintRequest = response;
     return request;

src/utils/rest.ts

@@ -9,6 +9,10 @@ interface MagicAPIResponse<TData = {}> {
   status?: string | number;
 }
 
+interface Headers {
+  [key: string]: any;
+}
+
 /**
  * Performs a `fetch` to the given URL with the configured `init` object.
  */
@@ -45,10 +49,15 @@ export function post<TBody extends Record<string, string | number | boolean> = {
   url: string,
   secretApiKey: string,
   body: TBody,
+  additionalHeaders?: Headers,
 ) {
+  let headers: Headers = { 'X-Magic-Secret-key': secretApiKey };
+  if (additionalHeaders) {
+    headers = { ...headers, ...additionalHeaders };
+  }
   return emitRequest<TResponse>(url, {
     method: 'POST',
-    headers: { 'X-Magic-Secret-key': secretApiKey },
+    headers,
     body: JSON.stringify(body),
   });
 }

test/spec/modules/nft/mint1155.spec.ts

@@ -45,6 +45,7 @@ test('Successfully POSTs to 1155 minting endpoint', async () => {
     'https://example.com/v1/admin/nft/mint/1155_mint',
     API_KEY,
     { contract_id: '0xfoo', quantity: 1, destination_address: '0xbar', token_id: 0 },
+    { 'Content-Type': 'application/json' },
   ]);
 });
 

test/spec/modules/nft/mint721.spec.ts

@@ -45,6 +45,7 @@ test('Successfully POSTs to 721 minting endpoint', async () => {
     'https://example.com/v1/admin/nft/mint/721_mint',
     API_KEY,
     { contract_id: '0xfoo', quantity: 1, destination_address: '0xbar' },
+    { 'Content-Type': 'application/json' },
   ]);
 });
 

test/spec/utils/rest/post.spec.ts

@@ -28,3 +28,30 @@ test('Successfully POSTs to the given endpoint & stringifies body', async () =>
     },
   ]);
 });
+
+test('Successfully POSTs to the given endpoint and adds JSON header', async () => {
+  const fetchStub = jest.fn().mockImplementation(() => successRes);
+  (fetch as any) = fetchStub;
+
+  await expect(
+    post(
+      'https://example.com/hello/world',
+      API_KEY,
+      { public_address: '0x0123' },
+      { 'Content-Type': 'application/json' },
+    ),
+  ).resolves.toBe('hello world');
+
+  const fetchArguments = fetchStub.mock.calls[0];
+  expect(fetchArguments).toEqual([
+    'https://example.com/hello/world',
+    {
+      method: 'POST',
+      headers: {
+        'X-Magic-Secret-key': API_KEY,
+        'Content-Type': 'application/json',
+      },
+      body: '{"public_address":"0x0123"}',
+    },
+  ]);
+});