Skip to content
This repository was archived by the owner on Sep 4, 2024. It is now read-only.

Commit e3676da

Browse files
authored
Merge pull request #5 from magiclabs/jerryliu-sc-62139-deprecation-of-testnet-in-mobile-sdks
* make chainId nullable
2 parents 33d4708 + 727d50c commit e3676da

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

link.magic.unity.sdk/Scripts/Magic.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,6 @@ public Magic(string apikey, CustomNodeConfiguration config, string locale = "en-
3939
public enum EthNetwork
4040
{
4141
Mainnet,
42-
Kovan,
43-
Rinkeby,
44-
Rposten
42+
Goerli,
4543
}
46-
}
44+
}

link.magic.unity.sdk/Scripts/Relayer/UrlBuilder.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using System;
2+
using JetBrains.Annotations;
23
using link.magic.unity.sdk.Utility;
34
using UnityEngine;
45

@@ -51,10 +52,10 @@ internal class CustomNodeOptions : BaseOptions
5152
[Serializable]
5253
public class CustomNodeConfiguration
5354
{
54-
[SerializeField] internal int chainId;
55+
[SerializeField] [CanBeNull] internal int? chainId;
5556
[SerializeField] internal string rpcUrl;
5657

57-
public CustomNodeConfiguration(string rpcUrl, int chainId)
58+
public CustomNodeConfiguration(string rpcUrl, int? chainId)
5859
{
5960
this.rpcUrl = rpcUrl;
6061
this.chainId = chainId;

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "link.magic.unity.sdk",
33
"displayName": "Magic Link Unity SDK",
44
"description": "The Magic Link Unity SDK provides access to Magic Key Management System and interact with Blockchain.",
5-
"version": "0.2.0",
5+
"version": "1.1.0",
66
"unity": "2021.3",
77
"author": {
88
"name": "Magic Labs Inc."

0 commit comments

Comments
 (0)