Skip to content

Commit 1e72bd9

Browse files
authored
fix external id editing conditions (#2528)
* fix external id editing conditions * fix typo
1 parent f626303 commit 1e72bd9

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/components/AdminPane/Manage/ManageChallenges/EditChallenge/Messages.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -659,7 +659,7 @@ will not be able to make sense of it.
659659
disableOsmIdProperty: {
660660
id: "Admin.EditChallenge.form.disableOsmIdProperty",
661661
defaultMessage:
662-
"This ID cannot be edited after challenge creation, this is to prevent task duplication. [Learn more](https://learn.maproulette.org/documentation/setting-external-task-identifiers/).",
662+
"This ID cannot be edited after a challenge has successfully created tasks, this is to prevent task duplication. [Learn more](https://learn.maproulette.org/documentation/setting-external-task-identifiers/).",
663663
},
664664

665665
customTaskStyleLabel: {

src/components/AdminPane/Manage/ManageChallenges/EditChallenge/Schemas/PropertiesSchema.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ export const jsSchema = (intl, user, challengeData) => {
5454
* > proper markup
5555
*/
5656
export const uiSchema = (intl, user, challengeData, extraErrors, options = {}) => {
57-
const sourceReadOnly = AsEditableChallenge(challengeData);
57+
const sourceReadOnly = !AsEditableChallenge(challengeData).hasZeroTasks();
5858
const isCollapsed = options.longForm && (options.collapsedGroups || []).indexOf(STEP_ID) === -1;
5959
const toggleCollapsed =
6060
options.longForm && options.toggleCollapsed

0 commit comments

Comments
 (0)