[packages] Fixes #527 - Added VisualStudio 2019 support.

- Added package VisualC-16 (note, no .0 suffix now, since it is intended to support all minor releases)
- AppVeyor CI updated to test against the latest VisualStudio 2019 support they provide
- Add new command line option, --VisualC.discoverprereleases, which allows vswhere to inspect prerelease editions too.
- Updated vswhere NuGet to version 2.6.7.
- Updated tests package definitions to include VisualC-16.
- Various fixes to scripts to support VisualStudio 2019.

Author: markfinal

.appveyor.yml

@@ -1,4 +1,5 @@
 image:
+  - Visual Studio 2019 Preview
   - Visual Studio 2017
   - Ubuntu
   - Ubuntu1804
@@ -16,6 +17,18 @@ for:
         - image: Ubuntu1804
     environment:
       GCC_VERSION: 7
+  - matrix:
+      only:
+        - image: Visual Studio 2017
+    environment:
+        VC_VERSION: 15.0
+        VC_PRERELEASE_ARGS:
+  - matrix:
+      only:
+        - image: Visual Studio 2019 Preview
+    environment:
+        VC_VERSION: 16
+        VC_PRERELEASE_ARGS: "--VisualC.discoverprereleases"
 install:
   - cmd: powershell choco install doxygen.portable --version 1.8.11 || exit 0
   - sh: ./codingtools/install_ubuntu_dependencies.sh
@@ -38,9 +51,9 @@ test_script:
   - cd bam_publish
   - cmd: "SET PATH=C:\\Python27-x64;%PATH%"
   - cmd: env.bat
-  - cmd: python tests\runtests.py -x Mingw --VisualC.version=15.0 -b Native -c debug -c profile -j0 -d
-  - cmd: python tests\runtests.py -x Mingw --VisualC.version=15.0 -b VSSolution -c debug -c profile -j0 -d
-  - cmd: python tests\runtests.py -x Mingw --VisualC.version=15.0 -b MakeFile -c debug -c profile -j0 -d --MakeFile.format=NMAKE
+  - cmd: python tests\runtests.py -x Mingw --VisualC.version=%VC_VERSION% %VC_PRERELEASE_ARGS% -b Native -c debug -c profile -j0 -d
+  - cmd: python tests\runtests.py -x Mingw --VisualC.version=%VC_VERSION% %VC_PRERELEASE_ARGS% -b VSSolution -c debug -c profile -j0 -d
+  - cmd: python tests\runtests.py -x Mingw --VisualC.version=%VC_VERSION% %VC_PRERELEASE_ARGS% -b MakeFile -c debug -c profile -j0 -d --MakeFile.format=NMAKE
   - sh: source env.sh
   - sh: python tests/runtests.py --Gcc.version=$GCC_VERSION -b Native -c debug -c profile -j0 -d
   - sh: python tests/runtests.py --Gcc.version=$GCC_VERSION -b MakeFile -c debug -c profile -j0 -d

Bam.Core/RunExecutableException.cs renamed to Bam.Core/Exceptions/RunExecutableException.cs

@@ -1,3 +1,11 @@
+06-Apr-2019 Fixes #527. Added VisualStudio 2019 support.
+- Added package VisualC-16 (note, no .0 suffix now, since it is intended to support all minor releases)
+- AppVeyor CI updated to test against the latest VisualStudio 2019 support they provide
+- Add new command line option, --VisualC.discoverprereleases, which allows vswhere to inspect prerelease editions too.
+- Updated vswhere NuGet to version 2.6.7.
+- Updated tests package definitions to include VisualC-16.
+- Various fixes to scripts to support VisualStudio 2019.
+
 03-Apr-2019 Fixes #526. Downloading and extracting package source archives now requires that a Module from the Package has been used in the build. This means that there may be packages with source archives that don't get downloaded on some platforms.
 
 09-Mar-2019 Fixes #525. Resolving a package, when there is both an unversioned and (many) versioned candidates no longer fails with a null dereference. I believe this is a rare situation - usually all candidates for a package will be versioned when there is more than one.

Changelog.txt

@@ -2,14 +2,27 @@
 
 from optparse import OptionParser
 import os
+import platform
 import subprocess
 import sys
 
+system = platform.system()
+if system == 'Windows':
+    bam_shell = 'bam.bat'
+else:
+    bam_shell = 'bam'
+
+
+def _log(message):
+    print >>sys.stdout, message
+    sys.stdout.flush()
+
 
 def get_bam_installdir():
-    args = ['bam', '--installdir']
-    install_dir = subprocess.check_output(args)
-    return install_dir
+    try:
+        return subprocess.check_output([bam_shell, '--installdir']).rstrip()
+    except WindowsError:
+        raise RuntimeError('Unable to locate BAM on the PATH')
 
 
 def get_bam_rootdir():
@@ -27,10 +40,9 @@ def get_bam_testsdir():
 def add_dependent(package_dir, name, version):
     current_dir = os.getcwd()
     try:
-        print >>sys.stdout, "Updating '%s'" % package_dir
-        sys.stdout.flush()
+        _log("Updating '%s'" % package_dir)
         os.chdir(package_dir)
-        args = ['bam', '--adddependent', '--pkgname=%s' % name]
+        args = [bam_shell, '--adddependent', '--pkgname=%s' % name]
         if version:
             args.append('--pkgversion=%s' % version)
         process = subprocess.Popen(args)
@@ -54,4 +66,3 @@ def process_path(tests_dir, name, version):
         parser.error('Package name is required')
     tests_dir = get_bam_testsdir()
     process_path(tests_dir, options.name, options.version)
-

codingtools/add_new_dependent_to_tests.py

@@ -32,7 +32,7 @@ namespace C.Options
     public sealed class DiscoverAllToolchains :
         Bam.Core.IBooleanCommandLineArgument
     {
-        string Bam.Core.ICommandLineArgument.ContextHelp => "All all toolchains to be discovered (no platform filtering)";
+        string Bam.Core.ICommandLineArgument.ContextHelp => "Allow all toolchains to be discovered (no platform filtering)";
         string Bam.Core.ICommandLineArgument.LongName => "--C.discoveralltoolchains";
         string Bam.Core.ICommandLineArgument.ShortName => null;
     }

packages/C/bam/Scripts/Options/DiscoverAllToolchains.cs

@@ -0,0 +1,41 @@
+#region License
+// Copyright (c) 2010-2019, Mark Final
+// All rights reserved.
+//
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are met:
+//
+// * Redistributions of source code must retain the above copyright notice, this
+//   list of conditions and the following disclaimer.
+//
+// * Redistributions in binary form must reproduce the above copyright notice,
+//   this list of conditions and the following disclaimer in the documentation
+//   and/or other materials provided with the distribution.
+//
+// * Neither the name of BuildAMation nor the names of its
+//   contributors may be used to endorse or promote products derived from
+//   this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+// AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+// DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+// FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+// DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+// SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+// CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+// OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+#endregion // License
+namespace VisualC
+{
+    public sealed class ArchiverSettings :
+        VisualCCommon.CommonArchiverSettings
+    {
+        public ArchiverSettings(
+            Bam.Core.Module module)
+            :
+            base(module)
+        { }
+    }
+}

packages/VisualC-16/bam/Scripts/ArchiverSettings.cs

@@ -0,0 +1,41 @@
+#region License
+// Copyright (c) 2010-2019, Mark Final
+// All rights reserved.
+//
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are met:
+//
+// * Redistributions of source code must retain the above copyright notice, this
+//   list of conditions and the following disclaimer.
+//
+// * Redistributions in binary form must reproduce the above copyright notice,
+//   this list of conditions and the following disclaimer in the documentation
+//   and/or other materials provided with the distribution.
+//
+// * Neither the name of BuildAMation nor the names of its
+//   contributors may be used to endorse or promote products derived from
+//   this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+// AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+// DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+// FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+// DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+// SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+// CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+// OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+#endregion // License
+namespace VisualC
+{
+    public sealed class AssemblerSettings :
+        VisualCCommon.CommonAssemblerSettings
+    {
+        public AssemblerSettings(
+            Bam.Core.Module module)
+            :
+            base(module)
+        { }
+    }
+}

packages/VisualC-16/bam/Scripts/AssemblerSettings.cs

@@ -0,0 +1,48 @@
+#region License
+// Copyright (c) 2010-2019, Mark Final
+// All rights reserved.
+//
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are met:
+//
+// * Redistributions of source code must retain the above copyright notice, this
+//   list of conditions and the following disclaimer.
+//
+// * Redistributions in binary form must reproduce the above copyright notice,
+//   this list of conditions and the following disclaimer in the documentation
+//   and/or other materials provided with the distribution.
+//
+// * Neither the name of BuildAMation nor the names of its
+//   contributors may be used to endorse or promote products derived from
+//   this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+// AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+// DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+// FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+// DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+// SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+// CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+// OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+#endregion // License
+namespace VisualC
+{
+    public sealed class CCompilerSettings :
+        VisualCCommon.CommonCCompilerSettings
+    {
+        public CCompilerSettings(
+            Bam.Core.Module module)
+            :
+            base(module)
+        { }
+
+        public CCompilerSettings(
+            Bam.Core.Module module,
+            bool useDefaults)
+            :
+            base(module, useDefaults)
+        { }
+    }
+}

packages/VisualC-16/bam/Scripts/CompilerSettings.cs

@@ -0,0 +1,49 @@
+#region License
+// Copyright (c) 2010-2019, Mark Final
+// All rights reserved.
+//
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are met:
+//
+// * Redistributions of source code must retain the above copyright notice, this
+//   list of conditions and the following disclaimer.
+//
+// * Redistributions in binary form must reproduce the above copyright notice,
+//   this list of conditions and the following disclaimer in the documentation
+//   and/or other materials provided with the distribution.
+//
+// * Neither the name of BuildAMation nor the names of its
+//   contributors may be used to endorse or promote products derived from
+//   this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+// AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+// DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+// FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+// DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+// SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+// CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+// OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+#endregion // License
+namespace VisualC
+{
+    public sealed class CxxCompilerSettings :
+        VisualCCommon.CommonCxxCompilerSettings,
+        C.ICxxOnlyCompilerSettings
+    {
+        public CxxCompilerSettings(
+            Bam.Core.Module module)
+            :
+            base(module, true)
+        { }
+
+        public CxxCompilerSettings(
+            Bam.Core.Module module,
+            bool useDefaults)
+            :
+            base(module, useDefaults)
+        { }
+    }
+}

packages/VisualC-16/bam/Scripts/CxxCompilerSettings.cs

@@ -0,0 +1,41 @@
+#region License
+// Copyright (c) 2010-2019, Mark Final
+// All rights reserved.
+//
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are met:
+//
+// * Redistributions of source code must retain the above copyright notice, this
+//   list of conditions and the following disclaimer.
+//
+// * Redistributions in binary form must reproduce the above copyright notice,
+//   this list of conditions and the following disclaimer in the documentation
+//   and/or other materials provided with the distribution.
+//
+// * Neither the name of BuildAMation nor the names of its
+//   contributors may be used to endorse or promote products derived from
+//   this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+// AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+// DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+// FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+// DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+// SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+// CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+// OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+#endregion // License
+namespace VisualC
+{
+    public sealed class LinkerSettings :
+        VisualCCommon.CommonLinkerSettings
+    {
+        public LinkerSettings(
+            Bam.Core.Module module)
+            :
+            base(module)
+        { }
+    }
+}