[packages,XcodeBuilder] Fixes #246. Added synchronization for more Xcode generation functions.

Author: markfinal

Changelog.txt

@@ -1,3 +1,5 @@
+18-May-2016 Fixes #246. Added synchronization for more Xcode generation functions.
+
 10-May-2016 ======== Version 1.0.2 beta 3 Release ========
 
 09-May-2016 Fixes #192. Bam.Core now exposes IOWrapper.CreateDirectory and IOWrapper.CreateDirectoryIfNotExists functions, which wrap around System.IO.Directory.CreateDirectory (and System.IO.Directory.Exists for the latter), but which importantly re-throw any exceptions caught from directory creation and includes the failing path in the exception message, which the System methods do not.

packages/XcodeBuilder/bam/Scripts/Target.cs

@@ -183,13 +183,16 @@ public void
             FileReference.EFileType type,
             Target.EProductType productType)
         {
-            this.SetProductType(productType);
-
-            var fileRef = this.Project.EnsureFileReferenceExists(path, type, sourceTree: FileReference.ESourceTree.BuiltProductsDir);
-            if (null == this.FileReference)
+            lock (this)
             {
-                this.FileReference = fileRef;
-                this.Project.ProductRefGroup.AddChild(fileRef);
+                this.SetProductType(productType);
+
+                var fileRef = this.Project.EnsureFileReferenceExists(path, type, sourceTree: FileReference.ESourceTree.BuiltProductsDir);
+                if (null == this.FileReference)
+                {
+                    this.FileReference = fileRef;
+                    this.Project.ProductRefGroup.AddChild(fileRef);
+                }
             }
         }
 
@@ -198,19 +201,21 @@ private BuildFile
             Bam.Core.TokenizedString path,
             FileReference.EFileType type)
         {
-            var fileRef = this.Project.EnsureFileReferenceExists(
-                path,
-                type,
-                sourceTree: FileReference.ESourceTree.Absolute);
-            var buildFile = this.Project.EnsureBuildFileExists(fileRef, this);
-            return buildFile;
+            lock (this.Project)
+            {
+                var fileRef = this.Project.EnsureFileReferenceExists(
+                    path,
+                    type,
+                    sourceTree: FileReference.ESourceTree.Absolute);
+                var buildFile = this.Project.EnsureBuildFileExists(fileRef, this);
+                return buildFile;
+            }
         }
 
         private Group
         CreateGroupHierarchy(
             Bam.Core.TokenizedString path)
         {
-            Group group = null;
             lock (this.Project)
             {
                 var found = this.Project.GroupMap.Where(item => item.Key == path.Parse()).FirstOrDefault();
@@ -219,7 +224,7 @@ private Group
                     return found.Value;
                 }
                 var basename = this.Module.CreateTokenizedString("@basename($(0))", path).Parse();
-                group = new Group(basename);
+                var group = new Group(basename);
                 this.Project.Groups.Add(group);
                 this.Project.GroupMap.Add(path.Parse(), group);
                 if (path.Parse().Contains(System.IO.Path.DirectorySeparatorChar))
@@ -228,8 +233,8 @@ private Group
                     var parentGroup = this.CreateGroupHierarchy(parent);
                     parentGroup.AddChild(group);
                 }
+                return group;
             }
-            return group;
         }
 
         private void
@@ -311,7 +316,10 @@ public void
         EnsureHeaderFileExists(
             Bam.Core.TokenizedString path)
         {
-            this.EnsureFileOfTypeExists(path, FileReference.EFileType.HeaderFile);
+            lock (this)
+            {
+                this.EnsureFileOfTypeExists(path, FileReference.EFileType.HeaderFile);
+            }
         }
 
         public void