fix: serializer - ensure circular references of registered functions are all assigned

Author: rturnq

.changeset/hungry-needles-shave.md

@@ -0,0 +1,5 @@
+---
+"@marko/runtime-tags": patch
+---
+
+Fix serializer to ensure circular references to registered functions all all assigned

packages/runtime-tags/src/__tests__/fixtures/return-serialize-circular-object/__snapshots__/.name-cache.json

@@ -0,0 +1,14 @@
+{
+  "vars": {
+    "props": {
+      "$_": "t",
+      "$init": "r",
+      "$$z__OR__x__OR__setter": "e",
+      "$$z": "o",
+      "$$count": "n",
+      "$$setCount__script": "m",
+      "$$input_value__OR__setter": "s",
+      "$$input_value": "u"
+    }
+  }
+}

packages/runtime-tags/src/__tests__/fixtures/return-serialize-circular-object/__snapshots__/csr-sanitized.expected.md

@@ -0,0 +1,14 @@
+# Render
+```html
+<div>
+  0
+</div>
+```
+
+
+# Render ASYNC
+```html
+<div>
+  1
+</div>
+```

packages/runtime-tags/src/__tests__/fixtures/return-serialize-circular-object/__snapshots__/csr.expected.md

@@ -0,0 +1,23 @@
+# Render
+```html
+<div>
+  0
+</div>
+```
+
+# Mutations
+```
+INSERT div
+```
+
+# Render ASYNC
+```html
+<div>
+  1
+</div>
+```
+
+# Mutations
+```
+UPDATE div/#text "0" => "1"
+```

packages/runtime-tags/src/__tests__/fixtures/return-serialize-circular-object/__snapshots__/dom.expected/tags/setter.js

@@ -0,0 +1,29 @@
+export const $template = "";
+export const $walks = "";
+export const $setup = () => {};
+import * as _ from "@marko/runtime-tags/debug/dom";
+const $input_value__OR__setter = /* @__PURE__ */_._or(5, $scope => {
+  let {
+    input_value,
+    setter
+  } = $scope;
+  _._return($scope, (input_value, setter));
+});
+const $setter2 = /* @__PURE__ */_._const("setter", $input_value__OR__setter);
+export const $input_valueChange = /* @__PURE__ */_._const("input_valueChange", ($scope, input_valueChange) => $setter2($scope, {
+  fn: $setter($scope)
+}));
+export const $input_value = /* @__PURE__ */_._const("input_value", $input_value__OR__setter);
+export const $input = /* @__PURE__ */_._const("input", ($scope, input) => {
+  $input_valueChange($scope, input.valueChange);
+  $input_value($scope, input.value);
+});
+function $setter({
+  input_valueChange
+}) {
+  return function () {
+    input_valueChange(1);
+  };
+}
+_._resume("__tests__/tags/setter.marko_0/setter", $setter);
+export default /* @__PURE__ */_._template("__tests__/tags/setter.marko", $template, $walks, $setup, $input);

packages/runtime-tags/src/__tests__/fixtures/return-serialize-circular-object/__snapshots__/dom.expected/template.hydrate.js

@@ -0,0 +1,22 @@
+// size: 298 (min) 192 (brotli)
+const $input_value__OR__setter = _._or(5, ($scope) => {
+    let { 3: input_value, 4: setter } = $scope;
+    _._return($scope, setter);
+  }),
+  $input_value = _._const(3, $input_value__OR__setter);
+_._resume("a0", function ({ 2: input_valueChange }) {
+  return function () {
+    input_valueChange(1);
+  };
+});
+const $count = _._let(3, ($scope, count) => {
+    ($input_value($scope[0], count), _._text($scope[2], count));
+  }),
+  $setCount__script = _._script("b1", ({ 4: setCount }) => setCount.fn());
+(_._var_resume("b2", _._const(4, $setCount__script)),
+  _._resume("b0", function ($scope) {
+    return (_new_count) => {
+      $count($scope, _new_count);
+    };
+  }),
+  init());

packages/runtime-tags/src/__tests__/fixtures/return-serialize-circular-object/__snapshots__/dom.expected/template.js

@@ -0,0 +1,25 @@
+export const $template = `${_setter_template}<div> </div>`;
+export const $walks = /* beginChildWithVar, _setter_walks, endChild, next(1), get, out(1) */`0${_setter_walks}&D l`;
+import * as _ from "@marko/runtime-tags/debug/dom";
+import { $setup as _setter, $input_value as _setter_input_value, $input_valueChange as _setter_input_valueChange, $template as _setter_template, $walks as _setter_walks } from "./tags/setter.marko";
+const $count = /* @__PURE__ */_._let("count/3", ($scope, count) => {
+  _setter_input_value($scope["#childScope/0"], count);
+  _._text($scope["#text/2"], count);
+});
+export function $setup($scope) {
+  _._var($scope, "#childScope/0", $setCount);
+  _setter($scope["#childScope/0"]);
+  _setter_input_valueChange($scope["#childScope/0"], $valueChange($scope));
+  $count($scope, 0);
+}
+const $setCount__script = _._script("__tests__/template.marko_0_setCount", ({
+  setCount
+}) => setCount.fn());
+const $setCount = _._var_resume("__tests__/template.marko_0_setCount/var", /* @__PURE__ */_._const("setCount", $setCount__script));
+function $valueChange($scope) {
+  return _new_count => {
+    $count($scope, _new_count);
+  };
+}
+_._resume("__tests__/template.marko_0/valueChange", $valueChange);
+export default /* @__PURE__ */_._template("__tests__/template.marko", $template, $walks, $setup);

packages/runtime-tags/src/__tests__/fixtures/return-serialize-circular-object/__snapshots__/html.expected/tags/setter.js

@@ -0,0 +1,21 @@
+import * as _ from "@marko/runtime-tags/debug/html";
+export default _._template("__tests__/tags/setter.marko", input => {
+  const $scope0_reason = _._scope_reason();
+  const $scope0_id = _._scope_id();
+  const setter = {
+    fn: _._resume(function () {
+      input.valueChange(1);
+    }, "__tests__/tags/setter.marko_0/setter", $scope0_id)
+  };
+  const $return = (input.value, setter);
+  _._scope($scope0_id, {
+    input_valueChange: input.valueChange,
+    input_value: _._serialize_if($scope0_reason, /* input.valueChange */0) && input.value,
+    setter: _._serialize_if($scope0_reason, /* input.value */1) && setter
+  }, "__tests__/tags/setter.marko", 0, {
+    input_valueChange: ["input.valueChange"],
+    input_value: ["input.value"],
+    setter: "1:8"
+  });
+  return $return;
+});

packages/runtime-tags/src/__tests__/fixtures/return-serialize-circular-object/__snapshots__/html.expected/template.js

@@ -0,0 +1,26 @@
+import _setter from "./tags/setter.marko";
+import * as _ from "@marko/runtime-tags/debug/html";
+export default _._template("__tests__/template.marko", input => {
+  const $scope0_id = _._scope_id();
+  let count = 0;
+  const $childScope = _._peek_scope_id();
+  _._set_serialize_reason({
+    /* input.value */1: /* count */1
+  });
+  let setCount = _setter({
+    value: count,
+    valueChange: _._resume(_new_count => {
+      count = _new_count;
+    }, "__tests__/template.marko_0/valueChange", $scope0_id)
+  });
+  _._var($scope0_id, "#scopeOffset/1", $childScope, "__tests__/template.marko_0_setCount/var");
+  _._html(`<div>${_._escape(count)}${_._el_resume($scope0_id, "#text/2")}</div>`);
+  _._script($scope0_id, "__tests__/template.marko_0_setCount");
+  _._scope($scope0_id, {
+    setCount,
+    "#childScope/0": _._existing_scope($childScope)
+  }, "__tests__/template.marko", 0, {
+    setCount: "2:9"
+  });
+  _._resume_branch($scope0_id);
+});

packages/runtime-tags/src/__tests__/fixtures/return-serialize-circular-object/__snapshots__/resume-sanitized.expected.md

@@ -0,0 +1,14 @@
+# Render
+```html
+<div>
+  0
+</div>
+```
+
+
+# Render ASYNC
+```html
+<div>
+  1
+</div>
+```