Skip to content

Commit 5bf313e

Browse files
committed
minor changes
* Fixed failing tests * format_results() and format_sites() provide message instead of warning about extra columns
1 parent 10a2106 commit 5bf313e

File tree

7 files changed

+147
-189
lines changed

7 files changed

+147
-189
lines changed

R/format_results.R

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -95,10 +95,8 @@ format_results <- function(df, in_format, out_format, date_format = "m/d/Y",
9595
message("\tDropped ", toString(length(drop_col)), " columns")
9696
} else {
9797
df <- dplyr::select(df, dplyr::all_of(c(keep_col, drop_col)))
98-
warning(
99-
"\tUnable to rename ", toString(length(drop_col)), " columns: ",
100-
paste(drop_col, collapse = ", "),
101-
call. = FALSE
98+
message(
99+
"\tRetaining ", toString(length(drop_col)), " surplus columns"
102100
)
103101
}
104102

R/format_sites.R

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,10 +76,8 @@ format_sites <- function(df, in_format, out_format, drop_extra_col = TRUE) {
7676
message("\tDropped ", toString(length(drop_col)), " columns")
7777
} else {
7878
df <- dplyr::select(df, dplyr::all_of(c(keep_col, drop_col)))
79-
warning(
80-
"\tUnable to rename ", toString(length(drop_col)), " columns: ",
81-
paste(drop_col, collapse = ", "),
82-
call. = FALSE
79+
message(
80+
"\tRetaining ", toString(length(drop_col)), " surplus columns"
8381
)
8482
}
8583

R/utils_format_results.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -297,10 +297,10 @@ results_to_mwr <- function(.data) {
297297

298298
# Update qualifiers, result value
299299
q_under <- c(
300-
"<2B", "2-5B", "BQL", "BRL", "D>T", "DL", "IDL", "K", "LTGTE", "U"
300+
"<2B", "2-5B", "BQL", "BRL", "D>T", "DL", "IDL", "K", "LTGTE", "U", "BDL"
301301
)
302302

303-
q_over <- c("GT", "E", "EE")
303+
q_over <- c("GT", "E", "EE", "AQL")
304304

305305
dat <- .data %>%
306306
dplyr::mutate(

man/update_param.Rd

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/update_unit.Rd

Lines changed: 23 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)