A child feature branch merging into its parent feature branch breaks plugin version checkout

[samjf]

I'll leave this one here so we have it documented as a possible problem.

When a child feature branch is merging into its parent feature branch will cause the dependent plugin to checkout the latest version. In my case it causes 5.x to be checked out when its parent is based off 4.x. This causes some troubles with testing of course.

Recreation

• Create a feature branch feature-a based off a 4.x-dev plugin branch.
• Create another feature branch feature-b based off feature-a
• Run the tests for feature-b

Actual: 5.x is checked out for the dependent plugins
Expected: 4.x version of the dependent plugin should be checked out.

Perhaps we can allow the base version to be defined so that this line will honor the intended Matomo version.

github-action-tests/action.yml

Line 185 in d52ff9f

TARGET_BRANCH: ${{ github.base_ref || github.ref_name }}