Skip to content

Commit 703cb75

Browse files
authored
fixed deps on each job for running (#414)
## Summary Modify the release pipeline workflow to ensure plugins and bifrost-http release jobs always run when needed, regardless of previous job statuses. ## Changes - Added `always()` condition to the `plugins-release` job to ensure it runs when needed even if previous jobs fail - Added `always()` condition to the `bifrost-http-release` job for the same reason - This ensures that all components can be released independently when they have changes ## Type of change - [x] Bug fix - [ ] Feature - [ ] Refactor - [ ] Documentation - [x] Chore/CI ## Affected areas - [ ] Core (Go) - [x] Transports (HTTP) - [ ] Providers/Integrations - [x] Plugins - [ ] UI (Next.js) - [ ] Docs ## How to test Verify the GitHub Actions workflow by triggering a release where multiple components have changes: ```sh # Trigger a release with changes to plugins and bifrost-http # Observe that both jobs run even if earlier jobs fail ``` ## Breaking changes - [ ] Yes - [x] No ## Related issues Fixes release pipeline issues where some components weren't being released when they should be. ## Security considerations No security implications as this only affects the release workflow. ## Checklist - [x] I read `docs/contributing/README.md` and followed the guidelines - [x] I verified the CI pipeline passes locally if applicable
2 parents d465bcf + 432e7c6 commit 703cb75

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/release-pipeline.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ jobs:
145145

146146
plugins-release:
147147
needs: [check-skip, detect-changes, core-release, framework-release]
148-
if: "needs.check-skip.outputs.should-skip != 'true' && needs.detect-changes.outputs.plugins-need-release == 'true' && (needs.detect-changes.outputs.core-needs-release == 'false' || needs.core-release.result == 'success' || needs.core-release.result == 'skipped') && (needs.detect-changes.outputs.framework-needs-release == 'false' || needs.framework-release.result == 'success' || needs.framework-release.result == 'skipped')"
148+
if: "always() && needs.check-skip.outputs.should-skip != 'true' && needs.detect-changes.outputs.plugins-need-release == 'true' && (needs.detect-changes.outputs.core-needs-release == 'false' || needs.core-release.result == 'success' || needs.core-release.result == 'skipped') && (needs.detect-changes.outputs.framework-needs-release == 'false' || needs.framework-release.result == 'success' || needs.framework-release.result == 'skipped')"
149149
runs-on: ubuntu-latest
150150
permissions:
151151
contents: write
@@ -200,7 +200,7 @@ jobs:
200200

201201
bifrost-http-release:
202202
needs: [check-skip, detect-changes, core-release, framework-release, plugins-release]
203-
if: "needs.check-skip.outputs.should-skip != 'true' && needs.detect-changes.outputs.bifrost-http-needs-release == 'true' && (needs.detect-changes.outputs.core-needs-release == 'false' || needs.core-release.result == 'success' || needs.core-release.result == 'skipped') && (needs.detect-changes.outputs.framework-needs-release == 'false' || needs.framework-release.result == 'success' || needs.framework-release.result == 'skipped') && (needs.detect-changes.outputs.plugins-need-release == 'false' || needs.plugins-release.result == 'success' || needs.plugins-release.result == 'skipped')"
203+
if: "always() && needs.check-skip.outputs.should-skip != 'true' && needs.detect-changes.outputs.bifrost-http-needs-release == 'true' && (needs.detect-changes.outputs.core-needs-release == 'false' || needs.core-release.result == 'success' || needs.core-release.result == 'skipped') && (needs.detect-changes.outputs.framework-needs-release == 'false' || needs.framework-release.result == 'success' || needs.framework-release.result == 'skipped') && (needs.detect-changes.outputs.plugins-need-release == 'false' || needs.plugins-release.result == 'success' || needs.plugins-release.result == 'skipped')"
204204
runs-on: ubuntu-latest
205205
permissions:
206206
contents: write

0 commit comments

Comments
 (0)