anonymous attachment resource support

Author: maxtepkeev

redmine/resources.py

@@ -448,15 +448,25 @@ class Attachment(_Resource):
     query_one = '/attachments/{0}.json'
 
     def __str__(self):
-        return to_string(self.filename)
+        try:
+            return to_string(self.filename)
+        except ResourceAttrError:
+            return str(self.id)
 
     def __repr__(self):
-        return '<{0}.{1} #{2} "{3}">'.format(
-            self.__class__.__module__,
-            self.__class__.__name__,
-            self.id,
-            to_string(self.filename)
-        )
+        try:
+            return '<{0}.{1} #{2} "{3}">'.format(
+                self.__class__.__module__,
+                self.__class__.__name__,
+                self.id,
+                to_string(self.filename)
+            )
+        except ResourceAttrError:
+            return '<{0}.{1} #{2}>'.format(
+                self.__class__.__module__,
+                self.__class__.__name__,
+                self.id
+            )
 
 
 class IssueJournal(_Resource):

tests/test_resources.py

@@ -566,10 +566,22 @@ def test_attachment_custom_str(self):
         self.response.json = json_response(responses['attachment']['get'])
         self.assertEqual(str(self.redmine.attachment.get(1)), 'foo.jpg')
 
+    def test_attachment_custom_str_without_filename(self):
+        self.response.json = json_response(responses['attachment']['get'])
+        attachment = self.redmine.attachment.get(1)
+        del attachment['_attributes']['filename']
+        self.assertEqual(str(attachment), '1')
+
     def test_attachment_custom_repr(self):
         self.response.json = json_response(responses['attachment']['get'])
         self.assertEqual(repr(self.redmine.attachment.get(1)), '<redmine.resources.Attachment #1 "foo.jpg">')
 
+    def test_attachment_custom_repr_without_subject(self):
+        self.response.json = json_response(responses['attachment']['get'])
+        attachment = self.redmine.attachment.get(1)
+        del attachment['_attributes']['filename']
+        self.assertEqual(repr(attachment), '<redmine.resources.Attachment #1>')
+
     def test_attachment_url(self):
         self.response.json = json_response(responses['attachment']['get'])
         self.assertEqual(self.redmine.attachment.get(1).url, '{0}/attachments/1'.format(self.url))