remove old hack for http create method

Author: maxtepkeev

redminelib/managers.py

@@ -176,17 +176,8 @@ def create(self, **fields):
             for index, attachment in enumerate(data['attachments']):
                 data['attachments'][index]['token'] = self.redmine.upload(attachment.get('path', ''))
 
-        # Almost all resources are created via POST method, but some
-        # resources are created via PUT, so we should check for this
-        try:
-            response = self.redmine.engine.request('post', url, data=data)
-        except exceptions.ResourceNotFoundError:
-            response = self.redmine.engine.request('put', url, data=data)
-
-        try:
-            resource = self.to_resource(response[self.container])
-        except TypeError:
-            raise exceptions.ValidationError('Resource already exists')  # fix for repeated PUT requests
+        response = self.redmine.engine.request(self.resource_class.http_method_create, url, data=data)
+        resource = self.to_resource(response[self.container])
 
         self.params = formatter.used_kwargs
         self.url = self.redmine.url + self.resource_class.query_one.format(resource.internal_id, **fields)
@@ -227,7 +218,7 @@ def update(self, resource_id, **fields):
             for index, attachment in enumerate(data['attachments']):
                 data['attachments'][index]['token'] = self.redmine.upload(attachment.get('path', ''))
 
-        return self.redmine.engine.request('put', url, data=data)
+        return self.redmine.engine.request(self.resource_class.http_method_update, url, data=data)
 
     def delete(self, resource_id, **params):
         """
@@ -245,7 +236,8 @@ def delete(self, resource_id, **params):
         except KeyError as exception:
             raise exceptions.ValidationError('{0} argument is required'.format(exception))
 
-        return self.redmine.engine.request('delete', url, params=self.resource_class.bulk_decode(params, self))
+        return self.redmine.engine.request(
+            self.resource_class.http_method_delete, url, params=self.resource_class.bulk_decode(params, self))
 
     def search(self, query, **options):
         """

redminelib/resources/base.py

@@ -94,6 +94,9 @@ class BaseResource(utilities.with_metaclass(Registrar)):
     query_update = None
     query_delete = None
     search_hints = None
+    http_method_create = 'post'
+    http_method_update = 'put'
+    http_method_delete = 'delete'
 
     _repr = [['id', 'name']]
     _includes = []

redminelib/resources/standard.py

@@ -229,6 +229,7 @@ class WikiPage(BaseResource):
     query_update = '/projects/{project_id}/wiki/{0}.json'
     query_delete = '/projects/{project_id}/wiki/{0}.json'
     search_hints = ['wiki-page']
+    http_method_create = 'put'
 
     _repr = [['title']]
     _includes = ['attachments']

tests/test_managers.py

@@ -181,10 +181,6 @@ def test_manager_is_picklable(self):
         self.assertEqual(project.url, unpickled_project.url)
         self.assertEqual(project.params['foo'], unpickled_project.params['foo'])
 
-    def test_create_validation_exception_via_put(self):
-        self.set_patch_side_effect([mock.Mock(status_code=404, history=[]), mock.Mock(status_code=200, history=[])])
-        self.assertRaises(exceptions.ValidationError, lambda: self.redmine.user.create(firstname='J', lastname='Smith'))
-
     def test_reraises_not_found_exception(self):
         self.response.status_code = 404
         self.assertRaises(exceptions.ResourceNotFoundError, lambda: self.redmine.project.get('non-existent-project'))