Skip to content

OPM_OVERLY_PERMISSIVE_METHOD suggests private when should be protected #512

@ben-manes

Description

@ben-manes
Code	Warning
OPM	This method ...CarrierPublisherHelper.setHazmat(Map, CarrierEntity) is declared more permissively than is used in the code base
Bug type OPM_OVERLY_PERMISSIVE_METHOD (click for details)
In class ...CarrierPublisherHelper
In method ...CarrierPublisherHelper.setHazmat(Map, CarrierEntity)
Value - Method declared public but could be declared private
At CarrierPublisherHelper.java:[lines 230-234]

I think this is because the base class is not abstract. I have another case where it could be package-private.

public class CarrierPublisherHelper implements GenericPublisherDelegate {...}

public class TruckmateCarrierPublisherHelper extends CarrierPublisherHelper {...}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions