Skip to content

Conversation

@tayllatheodoro
Copy link

Used "unique_ids==-1" to flag the use of reconstruct CLI to run the orchestrated pipeline.

Copy link
Collaborator

@talonchandler talonchandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transfer_function_dirpath,
ram_multiplier,
unique_id,
verbose
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing you forgot to add parsing.py to the commit? The test show this import is failing.

@codecov
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 10.57%. Comparing base (7687259) to head (84c0b5b).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
recOrder/cli/apply_inverse_transfer_function.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##            main     #504      +/-   ##
=========================================
+ Coverage   9.54%   10.57%   +1.03%     
=========================================
  Files         30       41      +11     
  Lines       4591     7347    +2756     
=========================================
+ Hits         438      777     +339     
- Misses      4153     6570    +2417     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@talonchandler talonchandler marked this pull request as draft March 7, 2025 01:26
@talonchandler
Copy link
Collaborator

I'm converting this to draft. @tayllatheodoro when you have a change to take another look let's repopen this against waveorder. Apologies for the minor headache here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants