Merge #273

bors[bot] · bidoubiwa · web-flow · commit d89ea76bca94 · 2021-02-18T12:05:40.000Z
273: Fix slice function that broke pagination r=bidoubiwa a=bidoubiwa

`splice` became `slice` during the whole typescript process 🙃

Co-authored-by: Charlotte Vermandel &lt;charlottevermandel@gmail.com&gt;
diff --git a/src/index.ts b/src/index.ts
@@ -73,7 +73,7 @@ export function instantMeiliSearch(
       if (this.pagination) {
         const nbPage = page || 0
         const start = nbPage * this.hitsPerPage!
-        const slicedMeiliSearchHits = meiliSearchHits.slice(
+        const slicedMeiliSearchHits = meiliSearchHits.splice(
           start,
           this.hitsPerPage
         )

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ export function instantMeiliSearch(`
`73`	`73`	`if (this.pagination) {`
`74`	`74`	`const nbPage = page \|\| 0`
`75`	`75`	`const start = nbPage * this.hitsPerPage!`
`76`		`- const slicedMeiliSearchHits = meiliSearchHits.slice(`
	`76`	`+ const slicedMeiliSearchHits = meiliSearchHits.splice(`
`77`	`77`	`start,`
`78`	`78`	`this.hitsPerPage`
`79`	`79`	`)`