Memfault Firmware SDK 1.30.0 (Build 15332)

Author: Memfault Inc

CHANGELOG.md

@@ -6,6 +6,57 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to
 [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.30.0] - 2025-09-23
+
+This is a minor release. Highlights:
+
+- Added active task stack collection control in Zephyr
+- Changed mount point selection for filesystem metric to look up from Zephyr
+  device tree fstab entries
+- Fixed potential WiFi stack overflow on nRF70 series devices during HTTP
+  uploads
+
+### 📈 Added
+
+- Zephyr
+
+  - Add Kconfig option
+    `CONFIG_MEMFAULT_COREDUMP_ACTIVE_TASK_STACK_SIZE_TO_COLLECT` to control how
+    much of the active task stack is collected in coredumps. This can be used to
+    prioritize capturing details about the running task when coredump storage
+    space is limited. Defaults to
+    `CONFIG_MEMFAULT_COREDUMP_STACK_SIZE_TO_COLLECT` for backwards
+    compatibility.
+
+  - Add the `mflt_http` workqueue thread to the default set of threads tracked
+    with max stack usage metrics. The default thread metrics can be controlled
+    with `CONFIG_MEMFAULT_METRICS_THREADS_DEFAULTS`.
+
+### 🛠️ Changed
+
+- Zephyr
+
+  - Replace use of deprecated API `bt_hci_cmd_create()` with
+    `bt_hci_cmd_alloc()` for Zephyr 4.2+.
+
+  - Enable `FileSystem_BytesFree` metric by default only when fstab is present
+    in the device tree. If present, the mount point is now automatically
+    detected from checking fstab nodes. Manual configuration of the mount point
+    via `CONFIG_MEMFAULT_FS_BYTES_FREE_VFS_PATH` still takes precedence when
+    set. If not using fstab, set `CONFIG_MEMFAULT_FS_BYTES_FREE_METRIC=y` to
+    enable collection.
+
+### 🐛 Fixed
+
+- nRF-Connect SDK:
+
+  - Increase the default value of
+    `CONFIG_MEMFAULT_HTTP_DEDICATED_WORKQUEUE_STACK_SIZE` to 4kB when uploading
+    via WiFi on the nRF70 series. This avoids potential stack overflows caused
+    while performing periodic uploads via HTTP. Thanks to
+    [@chshzh](https://github.com/chshzh) for reporting this and proposing a fix
+    in [#95](https://github.com/memfault/memfault-firmware-sdk/issues/95)!
+
 ## [1.29.0] - 2025-09-11
 
 This is a minor release. Highlights:

VERSION

@@ -1,3 +1,3 @@
-BUILD ID: 15235
-GIT COMMIT: e7a5241921
-VERSION: 1.29.0
+BUILD ID: 15332
+GIT COMMIT: a6e147605b
+VERSION: 1.30.0

components/include/memfault/version.h

@@ -20,8 +20,8 @@ typedef struct {
 } sMfltSdkVersion;
 
 #define MEMFAULT_SDK_VERSION \
-  { .major = 1, .minor = 29, .patch = 0 }
-#define MEMFAULT_SDK_VERSION_STR "1.29.0"
+  { .major = 1, .minor = 30, .patch = 0 }
+#define MEMFAULT_SDK_VERSION_STR "1.30.0"
 
 #ifdef __cplusplus
 }

examples/nrf-connect-sdk/nrf9160/memfault_demo_app/config/memfault_metrics_heartbeat_config.def

@@ -1,4 +1,3 @@
 // Thread stack usage metrics
-MEMFAULT_METRICS_KEY_DEFINE_WITH_SCALE_VALUE(memory_mflt_http_pct_max, kMemfaultMetricType_Unsigned, 100)
 MEMFAULT_METRICS_KEY_DEFINE_WITH_SCALE_VALUE(memory_wdt_pct_max, kMemfaultMetricType_Unsigned, 100)
 MEMFAULT_METRICS_KEY_DEFINE_WITH_SCALE_VALUE(memory_shell_uart_pct_max, kMemfaultMetricType_Unsigned, 100)

examples/nrf-connect-sdk/nrf9160/memfault_demo_app/prj.conf

@@ -83,7 +83,7 @@ CONFIG_WATCHDOG=y
 # Enable Zephyr runtime asserts
 CONFIG_ASSERT=y
 
-# Enable littlefs on intern al flash, to demo the file system utilization metric
+# Enable littlefs on internal flash, to demo the file system utilization metric
 CONFIG_FILE_SYSTEM=y
 CONFIG_FILE_SYSTEM_LITTLEFS=y
 CONFIG_FILE_SYSTEM_SHELL=y

ports/zephyr/Kconfig

@@ -171,6 +171,13 @@ config MEMFAULT_COREDUMP_STACK_SIZE_TO_COLLECT
         The larger the size, the more stack frames Memfault can recover for tasks. The
         default setting typically allows for 4 or more frames to be recovered.
 
+config MEMFAULT_COREDUMP_ACTIVE_TASK_STACK_SIZE_TO_COLLECT
+       int "Maximum amount of bytes to collect for active task"
+       default MEMFAULT_COREDUMP_STACK_SIZE_TO_COLLECT
+       help
+        The larger the size, the more stack frames Memfault can recover for the active task.
+        The default setting typically allows for 4 or more frames to be recovered.
+
 config MEMFAULT_COREDUMP_FULL_THREAD_STACKS
        bool "Collect full thread stacks in coredumps"
        default n
@@ -427,6 +434,7 @@ endchoice # MEMFAULT_HTTP_PERIODIC_UPLOAD_CONTEXT
 
 config MEMFAULT_HTTP_DEDICATED_WORKQUEUE_STACK_SIZE
         int "Stack size for dedicated http upload queue, in bytes"
+        default 4096 if WIFI_NRF70
         default 2048
         depends on MEMFAULT_HTTP_PERIODIC_UPLOAD_USE_DEDICATED_WORKQUEUE
 
@@ -649,16 +657,24 @@ config MEMFAULT_METRICS_DEFAULT_SET_ENABLE
 
 config MEMFAULT_FS_BYTES_FREE_METRIC
         bool "Enable a metric for the amount of free space on the filesystem"
-        default y
+        default y if "$(dt_path_enabled,/fstab)"
         depends on FILE_SYSTEM
+        help
+         Collects a metric for the amount of free space on the virtual filesystem.
+         If using fstab, the first mount point found will be used. Otherwise, the
+         user must update MEMFAULT_FS_BYTES_FREE_VFS_PATH to the mount point of
+         the filesystem to collect metrics for. Note: may be performance intensive
+         depending on flash technology and filesystem type.
 
 config MEMFAULT_FS_BYTES_FREE_VFS_PATH
         string "Path to the mount point to collect free space metrics for"
-        default "lfs1"
+        default ""
         depends on FILE_SYSTEM && MEMFAULT_FS_BYTES_FREE_METRIC
         help
          The path to the virtual filesystem mount point to collect free space
-         metrics for, omitting the leading '/'.
+         metrics for, omitting the leading '/'. If left empty and an fstab node
+         exists in the device tree, the first available mount point from the
+         fstab nodes will be used.
 
 config MEMFAULT_METRICS_CPU_TEMP
         bool "Enable CPU temperature metrics"

ports/zephyr/common/memfault_platform_coredump_regions.c

@@ -39,7 +39,7 @@ size_t memfault_zephyr_coredump_get_regions(const sCoredumpCrashInfo *crash_info
 
 #if CONFIG_MEMFAULT_COREDUMP_COLLECT_STACK_REGIONS
   size_t stack_size_to_collect = memfault_platform_sanitize_address_range(
-    crash_info->stack_address, CONFIG_MEMFAULT_COREDUMP_STACK_SIZE_TO_COLLECT);
+    crash_info->stack_address, CONFIG_MEMFAULT_COREDUMP_ACTIVE_TASK_STACK_SIZE_TO_COLLECT);
 
   regions[region_idx] =
     MEMFAULT_COREDUMP_MEMORY_REGION_INIT(crash_info->stack_address, stack_size_to_collect);
@@ -56,7 +56,7 @@ size_t memfault_zephyr_coredump_get_regions(const sCoredumpCrashInfo *crash_info
     // exception frame that will have been stacked on it as well
     const uint32_t extra_stack_bytes = 128;
     stack_size_to_collect = memfault_platform_sanitize_address_range(
-      psp, CONFIG_MEMFAULT_COREDUMP_STACK_SIZE_TO_COLLECT + extra_stack_bytes);
+      psp, CONFIG_MEMFAULT_COREDUMP_ACTIVE_TASK_STACK_SIZE_TO_COLLECT + extra_stack_bytes);
     regions[region_idx] = MEMFAULT_COREDUMP_MEMORY_REGION_INIT(psp, stack_size_to_collect);
     region_idx++;
   }

ports/zephyr/common/metrics/memfault_platform_bluetooth_metrics.c

@@ -74,7 +74,12 @@ static void prv_record_connection_rssi(struct bt_conn *conn) {
 
   struct bt_hci_cp_read_rssi *cp;
 
+  #if MEMFAULT_ZEPHYR_VERSION_GT(4, 1)
+  struct net_buf *buf = bt_hci_cmd_alloc(K_FOREVER);
+  #else
   struct net_buf *buf = bt_hci_cmd_create(BT_HCI_OP_READ_RSSI, sizeof(*cp));
+  #endif
+
   if (!buf) {
     return;
   }

ports/zephyr/common/metrics/memfault_platform_metrics.c

@@ -137,6 +137,56 @@ static void prv_collect_memory_usage_metrics(void) {
 }
 #endif  // defined(CONFIG_MEMFAULT_METRICS_MEMORY_USAGE)
 
+#if defined(CONFIG_MEMFAULT_FS_BYTES_FREE_METRIC)
+void prv_collect_fs_bytes_free_metric(void) {
+  const char *mount_point = NULL;
+
+  // User configured path takes priority
+  #ifdef CONFIG_MEMFAULT_FS_BYTES_FREE_VFS_PATH
+  char normalized_path[64];
+  if (CONFIG_MEMFAULT_FS_BYTES_FREE_VFS_PATH[0] != '\0') {
+    MEMFAULT_LOG_DEBUG("Using user-configured mount point for FS bytes free metric");
+    snprintf(normalized_path, sizeof(normalized_path), "/%s",
+             CONFIG_MEMFAULT_FS_BYTES_FREE_VFS_PATH);
+    mount_point = normalized_path;
+  }
+  #endif
+
+  // Auto-detect from fstab only
+  #if DT_NODE_EXISTS(DT_PATH(fstab))
+  MEMFAULT_LOG_DEBUG("Auto-detecting mount point from fstab for FS bytes free metric");
+
+    // Create a ternary chain to find the first mount point available
+    //
+    // The return statement here will expand to something like:
+    // return (DT_NODE_HAS_PROP(child1, mount_point) ? DT_PROP(child1, mount_point) :)
+    //        (DT_NODE_HAS_PROP(child2, mount_point) ? DT_PROP(child2, mount_point) :)
+    //        (DT_NODE_HAS_PROP(child3, mount_point) ? DT_PROP(child3, mount_point) :)
+    //         NULL;
+    #define FIND_FIRST_MOUNT(node_id) \
+      DT_NODE_HAS_PROP(node_id, mount_point) ? DT_PROP(node_id, mount_point):
+
+  mount_point = DT_FOREACH_CHILD_SEP(DT_PATH(fstab), FIND_FIRST_MOUNT, ) NULL;
+  #endif
+
+  if (mount_point == NULL) {
+    MEMFAULT_LOG_WARN("No mount point configured - skipping FS bytes free metric");
+    return;
+  }
+
+  MEMFAULT_LOG_DEBUG("Collecting FS bytes free metric for mount point %s", mount_point);
+
+  struct fs_statvfs fs_stats;
+  int retval = fs_statvfs(mount_point, &fs_stats);
+  if (retval == 0) {
+    // compute free bytes
+    uint32_t bytes_free = fs_stats.f_frsize * fs_stats.f_bfree;
+    MEMFAULT_METRIC_SET_UNSIGNED(FileSystem_BytesFree, bytes_free);
+  }
+}
+
+#endif /* CONFIG_MEMFAULT_FS_BYTES_FREE_METRIC */
+
 // Written as a function vs. in-line b/c we might want to extern this at some point?
 // See ports/zephyr/config/memfault_metrics_heartbeat_zephyr_port_config.def for
 // where the metrics key names come from.
@@ -181,20 +231,12 @@ void memfault_metrics_heartbeat_collect_sdk_data(void) {
     // for percentage conversion
     uint32_t usage_pct = (uint32_t)(non_idle_tasks_cycles_delta * 10000 / all_tasks_cycles_delta);
     MEMFAULT_METRIC_SET_UNSIGNED(cpu_usage_pct, usage_pct);
-    MEMFAULT_LOG_DEBUG("CPU usage: %u.%02u%%\n", usage_pct / 100, usage_pct % 100);
+    MEMFAULT_LOG_DEBUG("CPU usage: %u.%02u%%", usage_pct / 100, usage_pct % 100);
   }
   #endif  // MEMFAULT_ZEPHYR_VERSION_GT_STRICT(3, 0)
 
-  #if CONFIG_MEMFAULT_FS_BYTES_FREE_METRIC
-  {
-    struct fs_statvfs fs_stats;
-    int retval = fs_statvfs("/" CONFIG_MEMFAULT_FS_BYTES_FREE_VFS_PATH, &fs_stats);
-    if (retval == 0) {
-      // compute free bytes
-      uint32_t bytes_free = fs_stats.f_frsize * fs_stats.f_bfree;
-      MEMFAULT_METRIC_SET_UNSIGNED(FileSystem_BytesFree, bytes_free);
-    }
-  }
+  #if defined(CONFIG_MEMFAULT_FS_BYTES_FREE_METRIC)
+  prv_collect_fs_bytes_free_metric();
   #endif /* CONFIG_MEMFAULT_FS_BYTES_FREE_METRIC */
 
 #endif /* CONFIG_MEMFAULT_METRICS_DEFAULT_SET_ENABLE */

ports/zephyr/common/metrics/memfault_platform_thread_metrics.c

@@ -18,6 +18,12 @@
 
 MEMFAULT_WEAK MEMFAULT_METRICS_DEFINE_THREAD_METRICS(
 #if defined(CONFIG_MEMFAULT_METRICS_THREADS_DEFAULTS)
+  #if defined(CONFIG_MEMFAULT_HTTP_PERIODIC_UPLOAD_USE_DEDICATED_WORKQUEUE)
+  {
+    .thread_name = "mflt_http",
+    .stack_usage_metric_key = MEMFAULT_METRICS_KEY(memory_mflt_http_pct_max),
+  },
+  #endif
   {
     .thread_name = "idle",
     .stack_usage_metric_key = MEMFAULT_METRICS_KEY(memory_idle_pct_max),