Merge branch 'main' into feat/input-translation-triple-space

Author: guoyongchang

.changeset/seven-waves-roll.md

@@ -0,0 +1,5 @@
+---
+"@read-frog/extension": patch
+---
+
+fix: ensure language detection only occurs in the top frame to prevent race conditions with iframes

README.md

@@ -261,7 +261,7 @@ Check out the [Contribution Guide](https://readfrog.app/en/tutorial/code-contrib
         <br>
       </th>
     </tr>
-    <tr>
+    <!-- <tr>
       <td>
         <picture>
           <source media="(prefers-color-scheme: dark)" srcset="https://next.ossinsight.io/widgets/official/compose-recent-top-contributors/thumbnail.png?repo_id=967738751&image_size=auto&color_scheme=dark" width="373" height="auto">
@@ -274,7 +274,7 @@ Check out the [Contribution Guide](https://readfrog.app/en/tutorial/code-contrib
           <img alt="Performance Stats of mengxi-ream/read-frog - Last 28 days" src="https://next.ossinsight.io/widgets/official/compose-last-28-days-stats/thumbnail.png?repo_id=967738751&image_size=auto&color_scheme=light" width="655" height="auto">
         </picture>
       </td>
-    </tr>
+    </tr> -->
   </table>
 </a>
 

README.zh-CN.md

@@ -259,7 +259,7 @@ Read Frog 的愿景是为各个级别的语言学习者提供易于使用、智
         <br>
       </th>
     </tr>
-    <tr>
+    <!-- <tr>
       <td>
         <picture>
           <source media="(prefers-color-scheme: dark)" srcset="https://next.ossinsight.io/widgets/official/compose-recent-top-contributors/thumbnail.png?repo_id=967738751&image_size=auto&color_scheme=dark" width="373" height="auto">
@@ -272,7 +272,7 @@ Read Frog 的愿景是为各个级别的语言学习者提供易于使用、智
           <img alt="Performance Stats of mengxi-ream/read-frog - Last 28 days" src="https://next.ossinsight.io/widgets/official/compose-last-28-days-stats/thumbnail.png?repo_id=967738751&image_size=auto&color_scheme=light" width="655" height="auto">
         </picture>
       </td>
-    </tr>
+    </tr> -->
   </table>
 </a>
 

src/entrypoints/host.content/index.tsx

@@ -98,11 +98,14 @@ export default defineContentScript({
         if (manager.isActive) {
           manager.stop()
         }
-        const { detectedCodeOrUnd } = await getDocumentInfo()
-        const detectedCode: LangCodeISO6393 = detectedCodeOrUnd === 'und' ? 'eng' : detectedCodeOrUnd
-        await storage.setItem<LangCodeISO6393>(`local:${DETECTED_CODE_STORAGE_KEY}`, detectedCode)
-        // Notify background script that URL has changed, let it decide whether to automatically enable translation
-        void sendMessage('checkAndAskAutoPageTranslation', { url: to, detectedCodeOrUnd })
+        // Only the top frame should detect and set language to avoid race conditions from iframes
+        if (window === window.top) {
+          const { detectedCodeOrUnd } = await getDocumentInfo()
+          const detectedCode: LangCodeISO6393 = detectedCodeOrUnd === 'und' ? 'eng' : detectedCodeOrUnd
+          await storage.setItem<LangCodeISO6393>(`local:${DETECTED_CODE_STORAGE_KEY}`, detectedCode)
+          // Notify background script that URL has changed, let it decide whether to automatically enable translation
+          void sendMessage('checkAndAskAutoPageTranslation', { url: to, detectedCodeOrUnd })
+        }
       }
     }
 
@@ -129,11 +132,14 @@ export default defineContentScript({
       enabled ? void manager.start() : manager.stop()
     })
 
-    const { detectedCodeOrUnd } = await getDocumentInfo()
-    const initialDetectedCode: LangCodeISO6393 = detectedCodeOrUnd === 'und' ? 'eng' : detectedCodeOrUnd
-    await storage.setItem<LangCodeISO6393>(`local:${DETECTED_CODE_STORAGE_KEY}`, initialDetectedCode)
+    // Only the top frame should detect and set language to avoid race conditions from iframes
+    if (window === window.top) {
+      const { detectedCodeOrUnd } = await getDocumentInfo()
+      const initialDetectedCode: LangCodeISO6393 = detectedCodeOrUnd === 'und' ? 'eng' : detectedCodeOrUnd
+      await storage.setItem<LangCodeISO6393>(`local:${DETECTED_CODE_STORAGE_KEY}`, initialDetectedCode)
 
-    // Check if auto-translation should be enabled for initial page load
-    void sendMessage('checkAndAskAutoPageTranslation', { url: window.location.href, detectedCodeOrUnd })
+      // Check if auto-translation should be enabled for initial page load
+      void sendMessage('checkAndAskAutoPageTranslation', { url: window.location.href, detectedCodeOrUnd })
+    }
   },
 })