Skip to content

Commit 90f8632

Browse files
committed
Relax not-needed version condition
1 parent c112661 commit 90f8632

File tree

2 files changed

+2
-13
lines changed

2 files changed

+2
-13
lines changed

packages/definitions-parser/src/check-parse-results.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ async function checkNpm(
161161
log(" yarn not-needed " + yarnargs.join(" "));
162162
log(` git add --all && git commit -m "${name}: Provides its own types" && git push -u origin not-needed-${name}`);
163163
log(` And comment PR: This will deprecate \`@types/${name}\` in favor of just \`${name}\`. CC ${contributorUrls}`);
164-
if (semver.gt(`${major}.${minor}.0`, firstTypedVersion)) {
164+
if (semver.gte(`${major}.${minor}.0`, firstTypedVersion)) {
165165
log(" WARNING: our version is greater!");
166166
}
167167
if (dependedOn.has(name)) {

packages/definitions-parser/src/git.ts

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import {
2020
UncachedNpmInfoClient,
2121
NpmInfo,
2222
} from "@definitelytyped/utils";
23-
import * as semver from "semver";
2423
import { getAffectedPackages } from "./get-affected-packages";
2524

2625
export interface GitDiff {
@@ -130,8 +129,7 @@ export async function getAffectedPackagesFromDiff(
130129

131130
/**
132131
* 1. libraryName must exist on npm (SKIPPED and preferably/optionally have been the libraryName in just-deleted header)
133-
* 2. asOfVersion must be newer than `@types/name@latest` on npm
134-
* 3. `name@asOfVersion` must exist on npm
132+
* 2. `name@asOfVersion` must exist on npm
135133
*/
136134
export function checkNotNeededPackage(
137135
unneeded: NotNeededPackage,
@@ -145,15 +143,6 @@ export function checkNotNeededPackage(
145143
Unneeded packages have to be replaced with a package on npm.`
146144
);
147145
typings = assertDefined(typings, `Unexpected error: @types package not found for ${unneeded.fullNpmName}`);
148-
const latestTypings = assertDefined(
149-
typings.distTags.get("latest"),
150-
`Unexpected error: ${unneeded.fullNpmName} is missing the "latest" tag.`
151-
);
152-
assert(
153-
semver.gt(unneeded.version, latestTypings),
154-
`The specified version ${unneeded.version} of ${unneeded.libraryName} must be newer than the version
155-
it is supposed to replace, ${latestTypings} of ${unneeded.fullNpmName}.`
156-
);
157146
assert(
158147
source.versions.has(String(unneeded.version)),
159148
`The specified version ${unneeded.version} of ${unneeded.libraryName} is not on npm.`

0 commit comments

Comments
 (0)