Add Value override for has/get/setProperty, and deleteProperty API

Author: vineethkuttan

API/hermes_node_api/hermes_node_api.cpp

@@ -4538,11 +4538,13 @@ napi_status NAPI_CDECL napi_delete_property(
   if (objRes.getStatus() == vm::ExecutionStatus::EXCEPTION) {
     return env->setJSException();
   }
+  vm::Handle<vm::JSObject> objHandle =
+      env->runtime_.makeHandle<vm::JSObject>(*objRes);
 
-  vm::CallResult<bool> cr = vm::JSObject::deleteComputed(
-      env->runtime_.makeHandle<vm::JSObject>(*objRes),
+  vm::CallResult<bool> cr = objHandle->deleteComputed(
+      objHandle,
       env->runtime_,
-      asHandle(key));
+      asHandle(key),vm::PropOpFlags().plusThrowOnError());
   if (cr.getStatus() == vm::ExecutionStatus::EXCEPTION) {
     return env->setJSException();
   }

API/hermes_node_api_jsi/NodeApiJsiRuntime.cpp

@@ -269,9 +269,19 @@ class NodeApiJsiRuntime : public jsi::Runtime {
       override;
   jsi::Value getProperty(const jsi::Object &obj, const jsi::String &name)
       override;
+
+ #if JSI_VERSION >= 21
+  jsi::Value getProperty(const jsi::Object &obj, const jsi::Value &name) override;
+ #endif
+
   bool hasProperty(const jsi::Object &obj, const jsi::PropNameID &name)
       override;
   bool hasProperty(const jsi::Object &obj, const jsi::String &name) override;
+
+ #if JSI_VERSION >= 21
+  bool hasProperty(const jsi::Object &obj, const jsi::Value &name) override;
+#endif
+
   void setPropertyValue(
       JSI_CONST_10 jsi::Object &obj,
       const jsi::PropNameID &name,
@@ -281,6 +291,19 @@ class NodeApiJsiRuntime : public jsi::Runtime {
       const jsi::String &name,
       const jsi::Value &value) override;
 
+#if JSI_VERSION >= 21
+  void setPropertyValue(
+      const jsi::Object &obj,
+      const jsi::Value &name,
+      const jsi::Value &value) override;
+
+  void deleteProperty(const jsi::Object &obj, const jsi::PropNameID &name)
+      override;
+  void deleteProperty(const jsi::Object &obj, const jsi::String &name) override;
+
+  void deleteProperty(const jsi::Object &obj, const jsi::Value &name) override;
+#endif
+
   bool isArray(const jsi::Object &obj) const override;
   bool isArrayBuffer(const jsi::Object &obj) const override;
   bool isFunction(const jsi::Object &obj) const override;
@@ -921,6 +944,7 @@ class NodeApiJsiRuntime : public jsi::Runtime {
   napi_value getProperty(napi_value object, napi_value propertyId) const;
   void setProperty(napi_value object, napi_value propertyId, napi_value value)
       const;
+  void deleteProperty(napi_value object, napi_value propertyId) const;
   void setProperty(
       napi_value object,
       napi_value propertyId,
@@ -1741,6 +1765,15 @@ jsi::Value NodeApiJsiRuntime::getProperty(
   return toJsiValue(getProperty(getNodeApiValue(obj), getNodeApiValue(name)));
 }
 
+#if JSI_VERSION >= 21
+jsi::Value NodeApiJsiRuntime::getProperty(
+    const jsi::Object &obj,
+    const jsi::Value &name) {
+  NodeApiScope scope{*this};
+  return toJsiValue(getProperty(getNodeApiValue(obj), getNodeApiValue(name)));
+}
+#endif
+
 bool NodeApiJsiRuntime::hasProperty(
     const jsi::Object &obj,
     const jsi::PropNameID &name) {
@@ -1755,6 +1788,15 @@ bool NodeApiJsiRuntime::hasProperty(
   return hasProperty(getNodeApiValue(obj), getNodeApiValue(name));
 }
 
+#if JSI_VERSION >= 21
+bool NodeApiJsiRuntime::hasProperty(
+    const jsi::Object& obj,
+    const jsi::Value& name) {
+  NodeApiScope scope{*this};
+  return hasProperty(getNodeApiValue(obj), getNodeApiValue(name));
+}
+#endif
+
 void NodeApiJsiRuntime::setPropertyValue(
     JSI_CONST_10 jsi::Object &obj,
     const jsi::PropNameID &name,
@@ -1773,6 +1815,38 @@ void NodeApiJsiRuntime::setPropertyValue(
       getNodeApiValue(obj), getNodeApiValue(name), getNodeApiValue(value));
 }
 
+#if JSI_VERSION >= 21
+void NodeApiJsiRuntime::setPropertyValue(
+    const jsi::Object& obj,
+    const jsi::Value& name,
+    const jsi::Value& value) {
+  NodeApiScope scope{*this};
+  setProperty(
+      getNodeApiValue(obj), getNodeApiValue(name), getNodeApiValue(value));
+}
+
+void NodeApiJsiRuntime::deleteProperty(
+    const jsi::Object &obj,
+    const jsi::PropNameID &name) {
+  NodeApiScope scope{*this};
+  deleteProperty(getNodeApiValue(obj), getNodeApiValue(name));
+}
+
+void NodeApiJsiRuntime::deleteProperty(
+    const jsi::Object& obj,
+    const jsi::String& name) {
+  NodeApiScope scope{*this};
+  deleteProperty(getNodeApiValue(obj), getNodeApiValue(name));
+}
+
+void NodeApiJsiRuntime::deleteProperty(
+    const jsi::Object &obj,
+    const jsi::Value &name) {
+  NodeApiScope scope{*this};
+  deleteProperty(getNodeApiValue(obj), getNodeApiValue(name));
+}
+#endif
+
 bool NodeApiJsiRuntime::isArray(const jsi::Object &obj) const {
   NodeApiScope scope{*this};
   return isArray(getNodeApiValue(obj));
@@ -2862,6 +2936,14 @@ void NodeApiJsiRuntime::setProperty(
   CHECK_NAPI(jsrApi_->napi_set_property(env_, object, propertyId, value));
 }
 
+//Deletes object property value.
+void NodeApiJsiRuntime::deleteProperty(
+    napi_value object,
+    napi_value propertyId) const {
+  bool result{};
+  CHECK_NAPI(jsrApi_->napi_delete_property(env_, object, propertyId,&result));
+}
+
 // Sets object property value with the provided property accessibility
 // attributes.
 void NodeApiJsiRuntime::setProperty(

unittests/NodeApi/test/js-native-api/test_object/test.js

@@ -232,7 +232,9 @@ assert.strictEqual(newObject.test_string, 'test string');
   const obj = {};
 
   Object.defineProperty(obj, 'foo', { configurable: false });
-  assert.strictEqual(test_object.Delete(obj, 'foo'), false);
+  assert.throws(() => {
+    test_object.Delete(obj, 'foo');
+  }, /Property is not configurable/);
   assert.strictEqual('foo' in obj, true);
 }