Skip to content

Commit ced088c

Browse files
authored
chore: address some of the 1.56 api review feedback (#37542)
1 parent eb9ebbe commit ced088c

File tree

4 files changed

+32
-10
lines changed

4 files changed

+32
-10
lines changed

docs/src/api/class-page.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2682,14 +2682,14 @@ Returns whether the element is [visible](../actionability.md#visible). [`param:
26822682
* since: v1.56
26832683
- returns: <[Array]<[ConsoleMessage]>>
26842684

2685-
Returns up to 200 last console messages from this page. See [`event: Page.console`] for more details.
2685+
Returns up to (currently) 200 last console messages from this page. See [`event: Page.console`] for more details.
26862686

26872687

26882688
## async method: Page.pageErrors
26892689
* since: v1.56
26902690
- returns: <[Array]<[Error]>>
26912691

2692-
Returns up to 200 last page errors from this page. See [`event: Page.pageError`] for more details.
2692+
Returns up to (currently) 200 last page errors from this page. See [`event: Page.pageError`] for more details.
26932693

26942694

26952695
## method: Page.locator
@@ -3141,7 +3141,11 @@ return value resolves to `[]`.
31413141
* since: v1.56
31423142
- returns: <[Array]<[Request]>>
31433143

3144-
Returns up to 100 last network request from this page. See [`event: Page.request`] for more details.
3144+
Returns up to (currently) 100 last network request from this page. See [`event: Page.request`] for more details.
3145+
3146+
Returned requests should be accessed immediately, otherwise they might be collected to prevent unbounded memory growth as new requests come in. Once collected, retrieving most information about the request is impossible.
3147+
3148+
Note that requests reported through the [`event: Page.request`] request are not collected, so there is a trade off between efficient memory usage with [`method: Page.requests`] and the amount of available information reported through [`event: Page.request`].
31453149

31463150

31473151
## async method: Page.addLocatorHandler

packages/playwright-client/types/types.d.ts

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2285,7 +2285,7 @@ export interface Page {
22852285
}): Promise<void>;
22862286

22872287
/**
2288-
* Returns up to 200 last console messages from this page. See
2288+
* Returns up to (currently) 200 last console messages from this page. See
22892289
* [page.on('console')](https://playwright.dev/docs/api/class-page#page-event-console) for more details.
22902290
*/
22912291
consoleMessages(): Promise<Array<ConsoleMessage>>;
@@ -3605,7 +3605,7 @@ export interface Page {
36053605
opener(): Promise<null|Page>;
36063606

36073607
/**
3608-
* Returns up to 200 last page errors from this page. See
3608+
* Returns up to (currently) 200 last page errors from this page. See
36093609
* [page.on('pageerror')](https://playwright.dev/docs/api/class-page#page-event-page-error) for more details.
36103610
*/
36113611
pageErrors(): Promise<Array<Error>>;
@@ -3927,8 +3927,17 @@ export interface Page {
39273927
requestGC(): Promise<void>;
39283928

39293929
/**
3930-
* Returns up to 100 last network request from this page. See
3930+
* Returns up to (currently) 100 last network request from this page. See
39313931
* [page.on('request')](https://playwright.dev/docs/api/class-page#page-event-request) for more details.
3932+
*
3933+
* Returned requests should be accessed immediately, otherwise they might be collected to prevent unbounded memory
3934+
* growth as new requests come in. Once collected, retrieving most information about the request is impossible.
3935+
*
3936+
* Note that requests reported through the
3937+
* [page.on('request')](https://playwright.dev/docs/api/class-page#page-event-request) request are not collected, so
3938+
* there is a trade off between efficient memory usage with
3939+
* [page.requests()](https://playwright.dev/docs/api/class-page#page-requests) and the amount of available information
3940+
* reported through [page.on('request')](https://playwright.dev/docs/api/class-page#page-event-request).
39323941
*/
39333942
requests(): Promise<Array<Request>>;
39343943

packages/playwright-core/src/server/chromium/chromiumSwitches.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ export const chromiumSwitches = (assistantMode?: boolean, channel?: string) => [
5858
'--disable-dev-shm-usage',
5959
'--disable-extensions',
6060
'--disable-features=' + disabledFeatures(assistantMode).join(','),
61-
'--enable-features=CDPScreenshotNewSurface',
61+
process.env.PLAYWRIGHT_LEGACY_SCREENSHOT ? '' : '--enable-features=CDPScreenshotNewSurface',
6262
'--allow-pre-commit-input',
6363
'--disable-hang-monitor',
6464
'--disable-ipc-flooding-protection',

packages/playwright-core/types/types.d.ts

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2285,7 +2285,7 @@ export interface Page {
22852285
}): Promise<void>;
22862286

22872287
/**
2288-
* Returns up to 200 last console messages from this page. See
2288+
* Returns up to (currently) 200 last console messages from this page. See
22892289
* [page.on('console')](https://playwright.dev/docs/api/class-page#page-event-console) for more details.
22902290
*/
22912291
consoleMessages(): Promise<Array<ConsoleMessage>>;
@@ -3605,7 +3605,7 @@ export interface Page {
36053605
opener(): Promise<null|Page>;
36063606

36073607
/**
3608-
* Returns up to 200 last page errors from this page. See
3608+
* Returns up to (currently) 200 last page errors from this page. See
36093609
* [page.on('pageerror')](https://playwright.dev/docs/api/class-page#page-event-page-error) for more details.
36103610
*/
36113611
pageErrors(): Promise<Array<Error>>;
@@ -3927,8 +3927,17 @@ export interface Page {
39273927
requestGC(): Promise<void>;
39283928

39293929
/**
3930-
* Returns up to 100 last network request from this page. See
3930+
* Returns up to (currently) 100 last network request from this page. See
39313931
* [page.on('request')](https://playwright.dev/docs/api/class-page#page-event-request) for more details.
3932+
*
3933+
* Returned requests should be accessed immediately, otherwise they might be collected to prevent unbounded memory
3934+
* growth as new requests come in. Once collected, retrieving most information about the request is impossible.
3935+
*
3936+
* Note that requests reported through the
3937+
* [page.on('request')](https://playwright.dev/docs/api/class-page#page-event-request) request are not collected, so
3938+
* there is a trade off between efficient memory usage with
3939+
* [page.requests()](https://playwright.dev/docs/api/class-page#page-requests) and the amount of available information
3940+
* reported through [page.on('request')](https://playwright.dev/docs/api/class-page#page-event-request).
39323941
*/
39333942
requests(): Promise<Array<Request>>;
39343943

0 commit comments

Comments
 (0)