Move shard warning before fatal errors and simplify GHA constructor

Co-authored-by: Skn0tt <14912729+Skn0tt@users.noreply.github.com>

Author: Copilot

packages/playwright/src/reporters/markdown.ts

@@ -51,6 +51,17 @@ class MarkdownReporter implements Reporter {
   async onEnd(result: FullResult) {
     const summary = this._generateSummary();
     const lines: string[] = [];
+    if (this._options.shardDurationThreshold && result.shards) {
+      for (const shard of result.shards) {
+        if (shard.duration > this._options.shardDurationThreshold) {
+          const shardLabel = shard.shardIndex !== undefined ? `Shard ${shard.shardIndex}` : 'Shard';
+          const durationMins = Math.round(shard.duration / 60000);
+          const thresholdMins = Math.round(this._options.shardDurationThreshold / 60000);
+          lines.push(`:warning: **Warning: ${shardLabel} took ${durationMins} minutes, exceeding the ${thresholdMins} minute threshold.**`);
+          lines.push(``);
+        }
+      }
+    }
     if (this._fatalErrors.length)
       lines.push(`**${this._fatalErrors.length} fatal errors, not part of any test**`);
     if (summary.unexpected.length) {
@@ -76,18 +87,6 @@ class MarkdownReporter implements Reporter {
     lines.push(`**${summary.expected} passed${skipped}${didNotRun}**`);
     lines.push(``);
 
-    if (this._options.shardDurationThreshold && result.shards) {
-      for (const shard of result.shards) {
-        if (shard.duration > this._options.shardDurationThreshold) {
-          const shardLabel = shard.shardIndex !== undefined ? `Shard ${shard.shardIndex}` : 'Shard';
-          const durationMins = Math.round(shard.duration / 60000);
-          const thresholdMins = Math.round(this._options.shardDurationThreshold / 60000);
-          lines.push(`:warning: **Warning: ${shardLabel} took ${durationMins} minutes, exceeding the ${thresholdMins} minute threshold.**`);
-          lines.push(``);
-        }
-      }
-    }
-
     await this.publishReport(lines.join('\n'));
   }
 

tests/config/ghaMarkdownReporter.ts

@@ -34,8 +34,8 @@ function getGithubToken() {
 const octokit = getOctokit(getGithubToken());
 
 class GHAMarkdownReporter extends MarkdownReporter {
-  constructor(options: { configDir: string, outputFile?: string, shardDurationThreshold?: number }) {
-    super({ ...options, shardDurationThreshold: options.shardDurationThreshold ?? 25 * 60 * 1000 });
+  constructor(options: { configDir: string, outputFile?: string }) {
+    super({ ...options, shardDurationThreshold: 25 * 60 * 1000 });
   }
 
   override async publishReport(report: string) {