feature: Don't expand presets when running configure or build #4583
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request adds an enhancement to the CMake Tools extension by introducing a new configuration option, cmake.expandCMakePresets, which allows users to choose whether to expand CMake presets or use the preset name directly in the command line arguments. The default value for this new configuration is set to true.
Main objective is to gather feedback and ideas.
Although, this is against wishes of CMake documentation. This gives users clear choice and fixes many outstanding issues with the support of CMake Presets.
If this PR isn't accepted I will create a fork of CMake Tools with argument expansion entirely removed as it's the only reason I don't use this excellent extension.
Key Changes
Updated package.json to include new configuration cmake.expandCMakePresets.
Source Code Updates:
Updated CMakeProject and CMakeDriver classes to handle the new configuration option.
Modified methods within cmakeProject.ts, cmakeDriver.ts, cmakeFileApiDriver.ts, cmakeLegacyDriver.ts, and cmakeServerDriver.ts to conditionally expand or use preset names based on expandCMakePresets.