Merge branch 'isidorn/diverse-wallaby' into copilot/sub-pr-2439

Author: benibenj

.claude/CLAUDE.md

@@ -0,0 +1,7 @@
+# Claude Instructions
+
+## General Repository Instructions
+
+For all repository instructions, coding standards, and development guidelines, **ALWAYS** read:
+
+**[.github/copilot-instructions.md](../.github/copilot-instructions.md)**

.esbuild.ts

@@ -10,7 +10,7 @@ import { copyFile, mkdir } from 'fs/promises';
 import { glob } from 'glob';
 import * as path from 'path';
 
-const REPO_ROOT = path.join(__dirname);
+const REPO_ROOT = import.meta.dirname;
 const isWatch = process.argv.includes('--watch');
 const isDev = process.argv.includes('--dev');
 const isPreRelease = process.argv.includes('--prerelease');
@@ -45,7 +45,10 @@ const baseNodeBuildOptions = {
 	platform: 'node',
 	mainFields: ["module", "main"], // needed for jsonc-parser,
 	define: {
-		'process.env.APPLICATIONINSIGHTS_CONFIGURATION_CONTENT': '"{}"'
+		'process.env.APPLICATIONINSIGHTS_CONFIGURATION_CONTENT': JSON.stringify(JSON.stringify({
+			proxyHttpUrl: "",
+			proxyHttpsUrl: ""
+		}))
 	},
 } satisfies esbuild.BuildOptions;
 
@@ -251,8 +254,8 @@ const nodeSimulationWorkbenchUIBuildOptions = {
 
 async function typeScriptServerPluginPackageJsonInstall(): Promise<void> {
 	await mkdir('./node_modules/@vscode/copilot-typescript-server-plugin', { recursive: true });
-	const source = path.join(__dirname, './src/extension/typescriptContext/serverPlugin/package.json');
-	const destination = path.join(__dirname, './node_modules/@vscode/copilot-typescript-server-plugin/package.json');
+	const source = path.join(import.meta.dirname, './src/extension/typescriptContext/serverPlugin/package.json');
+	const destination = path.join(import.meta.dirname, './node_modules/@vscode/copilot-typescript-server-plugin/package.json');
 	try {
 		await copyFile(source, destination);
 	} catch (error) {
@@ -369,7 +372,7 @@ async function main() {
 }
 
 function applyPackageJsonPatch(isPreRelease: boolean) {
-	const packagejsonPath = path.join(__dirname, './package.json');
+	const packagejsonPath = path.join(import.meta.dirname, './package.json');
 	const json = JSON.parse(fs.readFileSync(packagejsonPath).toString());
 
 	const newProps: any = {

.eslintplugin/index.js

@@ -0,0 +1,19 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+import type { LooseRuleDefinition } from '@typescript-eslint/utils/ts-eslint';
+import * as glob from 'glob';
+import path from 'path';
+
+// Re-export all .ts files as rules
+const rules: Record<string, LooseRuleDefinition> = {};
+await Promise.all(
+	glob.sync('*.ts', { cwd: import.meta.dirname })
+		.filter(file => !file.endsWith('index.ts') && !file.endsWith('utils.ts'))
+		.map(async file => {
+			rules[path.basename(file, '.ts')] = (await import('./' + file)).default;
+		})
+);
+
+export { rules };

.eslintplugin/index.ts

@@ -5,13 +5,13 @@
 
 import * as eslint from 'eslint';
 
-export = new class NoBadGDPRComment implements eslint.Rule.RuleModule {
+export default new class NoBadGDPRComment implements eslint.Rule.RuleModule {
 
 	create(context: eslint.Rule.RuleContext): eslint.Rule.RuleListener {
 
 		return {
 			['Program'](node) {
-				for (const comment of (<eslint.AST.Program>node).comments) {
+				for (const comment of (node as eslint.AST.Program).comments) {
 					if (comment.type !== 'Block' || !comment.loc) {
 						continue;
 					}

.eslintplugin/no-bad-gdpr-comment.ts

@@ -7,7 +7,7 @@ import * as eslint from 'eslint';
 import { readdirSync } from 'fs';
 import path from 'path';
 
-export = new class NoTestOnly implements eslint.Rule.RuleModule {
+export default new class NoTestOnly implements eslint.Rule.RuleModule {
 
 	create(context: eslint.Rule.RuleContext): eslint.Rule.RuleListener {
 

.eslintplugin/no-funny-filename.ts

@@ -6,7 +6,7 @@
 import { TSESTree } from '@typescript-eslint/typescript-estree';
 import * as eslint from 'eslint';
 
-export = new class NoGDPREventNameMismatch implements eslint.Rule.RuleModule {
+export default new class NoGDPREventNameMismatch implements eslint.Rule.RuleModule {
 
 	readonly meta: eslint.Rule.RuleMetaData = {
 		type: "problem",
@@ -56,7 +56,7 @@ export = new class NoGDPREventNameMismatch implements eslint.Rule.RuleModule {
 
 		return {
 			['ExpressionStatement MemberExpression Identifier[name=/^send.*TelemetryEvent$/]'](node: any) {
-				const esNode = <TSESTree.Identifier>node;
+				const esNode = node as TSESTree.Identifier;
 				const gdprCommentEventName = getEventNameFromLeadingGdprComment(esNode);
 				if (!gdprCommentEventName) {
 					return;

.eslintplugin/no-gdpr-event-name-mismatch.ts

@@ -5,7 +5,7 @@
 
 import * as eslint from 'eslint';
 
-export = new class NoInstanceofUri implements eslint.Rule.RuleModule {
+export default new class NoInstanceofUri implements eslint.Rule.RuleModule {
 	readonly meta: eslint.Rule.RuleMetaData = {
 		type: "problem",
 		fixable: "code",

.eslintplugin/no-instanceof-uri.ts

@@ -5,7 +5,7 @@
 
 import * as eslint from 'eslint';
 
-export = new class MissingTSXLinebreak implements eslint.Rule.RuleModule {
+export default new class MissingTSXLinebreak implements eslint.Rule.RuleModule {
 
 	readonly meta: eslint.Rule.RuleMetaData = {
 		type: "problem",

.eslintplugin/no-missing-linebreak.ts

@@ -4,9 +4,9 @@
  *--------------------------------------------------------------------------------------------*/
 
 import * as eslint from 'eslint';
-import { createImportRuleListener } from './utils';
+import { createImportRuleListener } from './utils.ts';
 
-export = new class implements eslint.Rule.RuleModule {
+export default new class implements eslint.Rule.RuleModule {
 
 	readonly meta: eslint.Rule.RuleMetaData = {
 		messages: {