Skip to content

Commit 950c506

Browse files
Apply suggestions from code review
Co-authored-by: Flor Chacón <14323496+florelis@users.noreply.github.com>
1 parent bea7944 commit 950c506

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

src/WingetCreateCLI/Common.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ public static string GetPathForDisplay(string path, bool substituteEnvironmentVa
8888
string localAppDataPath = Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData);
8989
string tempPath = Path.GetTempPath().TrimEnd(Path.DirectorySeparatorChar);
9090

91-
path = path.Replace("\\", Path.DirectorySeparatorChar.ToString());
91+
path = Path.GetFullPath(path);
9292

9393
if (path.StartsWith(tempPath, StringComparison.OrdinalIgnoreCase) && RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
9494
{

src/WingetCreateCLI/Properties/Resources.resx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -583,7 +583,7 @@
583583
<value>Telemetry Settings</value>
584584
</data>
585585
<data name="ManifestValidationUnavailableOnUnix_Message" xml:space="preserve">
586-
<value>Manifest validation is not available on Linux/macOS platforms.</value>
586+
<value>Manifest validation is only available on Windows.</value>
587587
</data>
588588
<data name="UnexpectedErrorLoadSettings_Message" xml:space="preserve">
589589
<value>Unexpected error while loading settings. Please verify your settings by running the settings command.</value>

src/WingetCreateCore/Common/MsixAndAppx.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,7 @@ public class MsixOrAppxPackage
3636
/// <summary>
3737
/// Gets metadata of APPX/MSIX package or bundle.
3838
/// </summary>
39-
#pragma warning disable SA1401 // Fields should be private
40-
public Metadata Information;
41-
#pragma warning restore SA1401 // Fields should be private
39+
public Metadata Information { get; set; }
4240

4341
/// <summary>
4442
/// Initializes a new instance of the <see cref="MsixOrAppxPackage"/> class.

0 commit comments

Comments
 (0)