Avoid Wrapping LumaImage in Arc, as it contains a mechanism for efficient cloning internally

Author: mineichen

pilatus-engineering/src/image/broadcaster.rs

@@ -51,7 +51,7 @@ impl<
                         );
                         if broadcaster
                             .send(BroadcastImage {
-                                image: Arc::new(output.image),
+                                image: output.image,
                                 hash: output.meta.hash,
                             })
                             .is_ok()

pilatus-engineering/src/image/message.rs

@@ -77,23 +77,20 @@ impl ActorMessage for SubscribeImageMessage {
 #[non_exhaustive]
 #[derive(Debug, Clone)]
 pub struct BroadcastImage {
-    pub image: Arc<LumaImage>,
+    pub image: LumaImage,
     pub hash: Option<StableHash>,
 }
 
 impl BroadcastImage {
-    pub fn with_hash(image: impl Into<Arc<LumaImage>>, hash: Option<StableHash>) -> Self {
-        Self {
-            image: image.into(),
-            hash,
-        }
+    pub fn with_hash(image: LumaImage, hash: Option<StableHash>) -> Self {
+        Self { image, hash }
     }
 }
 
 impl From<GetImageOk> for BroadcastImage {
     fn from(o: GetImageOk) -> Self {
         Self {
-            image: Arc::new(o.image),
+            image: o.image,
             hash: o.meta.hash,
         }
     }
@@ -113,19 +110,19 @@ impl From<LocalizableBroadcastImage> for BroadcastImage {
 #[non_exhaustive]
 #[derive(Clone)]
 pub struct LocalizableBroadcastImage {
-    pub image: Arc<LumaImage>,
+    pub image: LumaImage,
     pub hash: Option<StableHash>,
     pub projector: Option<DynamicPointProjector>,
 }
 
 impl LocalizableBroadcastImage {
     pub fn with_hash_and_projector(
-        image: impl Into<Arc<LumaImage>>,
+        image: LumaImage,
         hash: Option<StableHash>,
         projector: Option<DynamicPointProjector>,
     ) -> Self {
         Self {
-            image: image.into(),
+            image,
             hash,
             projector,
         }
@@ -166,7 +163,7 @@ pub struct GetLocalizableImageOk {
 impl From<GetLocalizableImageOk> for BroadcastImage {
     fn from(value: GetLocalizableImageOk) -> Self {
         Self {
-            image: Arc::new(value.image),
+            image: value.image,
             hash: value.hash,
         }
     }

pilatus-engineering/src/image/web.rs

@@ -7,7 +7,6 @@ use std::{
     fmt::{self, Debug, Formatter},
     marker::PhantomData,
     num::{NonZeroU32, NonZeroU8},
-    sync::Arc,
 };
 
 use anyhow::anyhow;
@@ -39,7 +38,7 @@ pub trait StreamableImage: Sized {
     fn encode(self) -> anyhow::Result<Vec<u8>>;
 }
 
-impl StreamableImage for Arc<LumaImage> {
+impl StreamableImage for LumaImage {
     fn encode(self) -> anyhow::Result<Vec<u8>> {
         let dims = self.dimensions();
         encode_legacy(self.buffer(), ColorType::Luma, dims, |_| Ok(()))
@@ -200,7 +199,7 @@ fn encode_dynamic_jpeg_image<T: Serialize>(
     }
 }
 
-impl<T: Serialize> StreamableImage for (Arc<LumaImage>, T) {
+impl<T: Serialize> StreamableImage for (LumaImage, T) {
     fn encode(self) -> anyhow::Result<Vec<u8>> {
         let dims = self.0.dimensions();
         encode_legacy(self.0.buffer(), ColorType::Luma, dims, |b| {