Skip to content

Allow tidy_draws to work with rstanarm models with a single variable #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Allow tidy_draws to work with rstanarm models with a single variable #333

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f13117f
fix 331
damonbayer Mar 20, 2025
034e177
don’t drop parameter name for single param
damonbayer Mar 20, 2025
7366217
remove extra line
damonbayer Mar 20, 2025
3450dec
Update description
damonbayer Mar 24, 2025
7b19016
Update test.tidy_draws.R
damonbayer Apr 2, 2025
2b72080
revise test to use actual model output
damonbayer Apr 2, 2025
5a110c8
restore blank line to test file
damonbayer Apr 2, 2025
26db78a
remove abind dependency
damonbayer Apr 2, 2025
ca55b8b
reproducible model
damonbayer Apr 2, 2025
6f286f7
add reproducible model to build_test_models
damonbayer Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ Imports:
posterior (>= 1.0.1),
withr,
cli,
vctrs
vctrs,
abind
Suggests:
knitr,
testthat,
Expand Down
4 changes: 2 additions & 2 deletions R/tidy_draws.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ tidy_draws.data.frame = function(model, ...) {
#' @export
tidy_draws.mcmc.list = function(model, ...) {
draws = do.call(rbind, lapply(seq_along(model), function(chain) {
n = nrow(model[[chain]])
n = coda::niter(model[[chain]])
iteration = seq_len(n)

add_column(
Expand Down Expand Up @@ -181,7 +181,7 @@ tidy_draws.stanreg = function(model, ...) {
#so we dont' just do tidy_draws(model$stanfit)
sample_matrix = as.array(model) #[iteration, chain, variable]
n_chain = dim(sample_matrix)[[2]]
mcmc_list = as.mcmc.list(lapply(seq_len(n_chain), function(chain) as.mcmc(sample_matrix[, chain, ]))) # nolint
mcmc_list = as.mcmc.list(lapply(seq_len(n_chain), function(chain) as.mcmc(abind::adrop(sample_matrix[, chain, , drop=FALSE], drop = 2)))) # nolint
draws = tidy_draws(mcmc_list, ...)
draws = add_rstan_sampler_param_draws(draws, model$stanfit)

Expand Down
Binary file added tests/models/models.rstanarm.one_var.rds
View file
Open in desktop
Binary file not shown.
7 changes: 7 additions & 0 deletions tests/testthat/test.tidy_draws.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,13 @@ test_that("tidy_draws works with rstanarm", {
expect_equal(tidy_draws(m_ranef), draws_tidy)
})

test_that("tidy_draws works with rstanarm models with one variable", {
skip_if_not_installed("rstanarm")

m_one_var = readRDS(test_path("../models/models.rstanarm.one_var.rds"))
expect_contains(colnames(tidy_draws(m_one_var)), "(Intercept)")
})


# rstan -------------------------------------------------------------------
test_that("tidy_draws works with rstan", {
Expand Down