fix: handle boolean exclusiveMaximum / exclusiveMinimum, improve test coverage #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnahkies
added a commit
that referenced
this pull request
Nov 30, 2025
adds a couple of missing unit tests, split from #386
mnahkies
added a commit
that referenced
this pull request
Nov 30, 2025
no behavior changes yet, split from #386
mnahkies
force-pushed
the
mn/test/boost-unit-test-coverage
branch
from
7e3a1cb to
3dafb23
Compare
mnahkies
added a commit
that referenced
this pull request
Nov 30, 2025
adds direct unit tests for input schema normalization, covering most branches. this will facilitate several improvements / bug fixes in subsequent changes, split from #386
mnahkies
force-pushed
the
mn/test/boost-unit-test-coverage
branch
from
3dafb23 to
46b988f
Compare
mnahkies
changed the base branch from
main
to
mn/fix/always-extract-request-bodies
mnahkies
added a commit
that referenced
this pull request
Nov 30, 2025
as written, these tests are using `Schema` types not normalized `IRModel` types for the input. this needs correcting before `Schema` and `IRModel` begin to diverge, split from #386
mnahkies
force-pushed
the
mn/fix/always-extract-request-bodies
branch
from
bb5ba1b to
d8bd80f
Compare
mnahkies
force-pushed
the
mn/test/boost-unit-test-coverage
branch
from
46b988f to
8006639
Compare
mnahkies
added a commit
that referenced
this pull request
Nov 30, 2025
wasn't causing issues yet, but will do once `IRModel` is no longer compatible with `Schema`, split from #386
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inputclass to make easier to directly testexclusiveMaximum/exclusiveMinimumon numbers being provided asbooleans, for backwards compatibility with earlier json schema definitions