🐛 Bug: Pending constructor does not inherit from the Error constructor

[mojwang]

I ran into the following annoying warning, thrown by Bluebird, when a test is skipped at runtime within a Bluebird promise chain.

Warning: a promise was rejected with a non-error: [object Object]

Some context on the warning thrown by Bluebird: http://bluebirdjs.com/docs/warning-explanations.html#warning-a-promise-was-rejected-with-a-non-error

Nevertheless, the root cause is that the Pending constructor in pending.js does not inherit from the Error constructor.

You can reproduce this by writing and running the following asynchronous test:

var Promise = require('bluebird');

Promise.config({
  warnings: true,
  longStackTraces: true
});

describe('Suite', function () { 
  it('Test', function () { 
    return Promise.bind(this).then(function () {
       this.skip();
    });
  });
});

Can this be fix?

[boneskull]

I'm not sure how difficult it would be to fix this, but it's definitely weird and wrong. You can of course disable the warnings as a workaround

[JoshuaKGoldberg]

The culprit:

mocha/lib/pending.js

Lines 9 to 16 in 7d3151d

	/**
	* Initialize a new `Pending` error with the given message.
	*
	* @param {string} message
	*/
	function Pending(message) {
	this.message = message;
	}

This issue will be easier once #5025 is resolved. Marking as blocked on that one.