Sulfur revision (#268)

* Change battery 1 to use steel instead of plastic

* Change sulfur prereq from oil proc to chem proc 2

* Fix unit test issues

Tech line now goes nickel-processing -> sulfur-processing -> oil-processing. Original sulfur recipe now goes on oil-processing.

* Fix sulfur unlock

Revamp mod will sometimes hide recipe "sulfur". Need to remove new unlock if it has been moved to oil processing

* Fix missing prerequisite

Module case requires plastic

---------

Co-authored-by: KiwiHawk <59639+KiwiHawk@users.noreply.github.com>

Author: Qatavin

boblogistics/prototypes/recipe/robots-recipe-updates.lua

@@ -77,6 +77,7 @@ end
 if data.raw.item["bob-module-case"] then
   if data.raw.recipe["bob-robot-brain"] then
     bobmods.lib.tech.add_recipe_unlock("robotics", "bob-module-case")
+    bobmods.lib.tech.add_prerequisite("robotics", "plastics")
     bobmods.lib.recipe.add_ingredient("bob-robot-brain", { type = "item", name = "bob-module-case", amount = 1 })
     bobmods.lib.recipe.add_ingredient("bob-robot-brain-2", { type = "item", name = "bob-module-case", amount = 1 })
     bobmods.lib.recipe.add_ingredient("bob-robot-brain-3", { type = "item", name = "bob-module-case", amount = 1 })

bobplates/data-updates.lua

@@ -105,12 +105,12 @@ else
 end
 
 if settings.startup["bobmods-plates-batteryupdate"].value == true then
-  data.raw.technology["battery"].prerequisites = { "sulfur-processing", "plastics", "lead-processing" }
+  data.raw.technology["battery"].prerequisites = { "sulfur-processing", "lead-processing" }
   bobmods.lib.recipe.clear_ingredients("battery")
 
   bobmods.lib.recipe.add_ingredient("battery", { type = "item", name = "bob-lead-plate", amount = 2 })
   bobmods.lib.recipe.add_ingredient("battery", { type = "fluid", name = "sulfuric-acid", amount = 20 })
-  bobmods.lib.recipe.add_ingredient("battery", { type = "item", name = "plastic-bar", amount = 1 })
+  bobmods.lib.recipe.add_ingredient("battery", { type = "item", name = "steel-plate", amount = 1 })
 end
 
 data.raw.recipe["steel-plate"].category = "chemical-furnace"

bobplates/prototypes/technology-updates.lua

@@ -16,6 +16,12 @@ if bobmods.electronics then
   bobmods.lib.tech.add_prerequisite("water-bore-1", "electronics")
 end
 
+bobmods.lib.tech.remove_prerequisite("sulfur-processing", "oil-processing")
+bobmods.lib.tech.add_prerequisite("oil-processing", "sulfur-processing")
+bobmods.lib.tech.add_prerequisite("sulfur-processing", "chemical-processing-2")
+bobmods.lib.tech.add_prerequisite("sulfur-processing", "nickel-processing")
+bobmods.lib.tech.remove_recipe_unlock("sulfur-processing", "sulfur")
+bobmods.lib.tech.add_recipe_unlock("oil-processing", "sulfur")
 bobmods.lib.tech.add_recipe_unlock("sulfur-processing", "sulfur-2")
 bobmods.lib.tech.add_recipe_unlock("sulfur-processing", "sulfur-3")
 bobmods.lib.tech.add_recipe_unlock("sulfur-processing", "sulfuric-acid-2")

bobrevamp/data-updates.lua

@@ -86,6 +86,7 @@ if
   and not settings.startup["bobmods-revamp-oil"].value == true
 then
   bobmods.lib.tech.remove_recipe_unlock("sulfur-processing", "sulfur")
+  bobmods.lib.tech.remove_recipe_unlock("oil-processing", "sulfur")
   bobmods.lib.recipe.hide("sulfur")
   bobmods.lib.tech.add_recipe_unlock("sulfur-processing", "oil-processing-with-sulfur")
 
@@ -100,6 +101,7 @@ end
 if settings.startup["bobmods-revamp-oil"].value == true then
   if data.raw.recipe["sulfur-2"] or data.raw.recipe["sulfur-3"] then
     bobmods.lib.tech.remove_recipe_unlock("sulfur-processing", "sulfur")
+    bobmods.lib.tech.remove_recipe_unlock("oil-processing", "sulfur")
     bobmods.lib.recipe.hide("sulfur")
   end
   bobmods.lib.tech.add_recipe_unlock("flammables", "solid-fuel-from-sour-gas")