Feature: Add dark theme as per system settings #2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This PR is based on the work of @omjamnekar. Many Thanks for your support. |
Contributor
|
Wouldn't it make sense to replace color codes with variable references as you've done for the |
Collaborator
Author
You're right, but that requires some more work. There are no predefined variables for the other colors. This is just a minimal version to use the existing PR. The next step will be to add this feature to the other themes and use the same color set with unique names. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1502.
Replaces #2010.
Moved all code from variables.css and common.css to theme/topside/theme.css to avoid side effects on other themes like theme 'focus'. This can be consolidated if every theme has a dark mode.